Repository navigation
path: a by-name lead on a value-callee site no longer hides the unknown verdict - #1813
Merged
Merged
Conversation
…wn verdict Symptom: path Svc.login Store.find, where Svc.login calls this.find() on a field holding promisify(s.find.bind(s)) with s untyped, printed "WOULD connect ... receiver not typed" and never said the connection is unknown or that the callee is a function stored in a field. path viaModule / Auth.login Store.find reported known_edge where the case wanted multi_inferred. Cause: two changes to the same shape landed together. The promisify rules made util.promisify(f) transparent (its value is what f holds) and dropped its platform value, so the wrapper-holder rules keyed on that platform value no longer fire. With a typed bound method the call now resolves straight to it (known_edge, one declaration); with an untyped one the call is an ordinary unresolved site, which the by-name search bridges and returns on before the value-callee report runs, although the engine still marks the site as a field value callee. Fix: the by-name branch skips a chain whose every bridge site is a value callee, so the value-callee report (UNKNOWN, the site, "named like the target") answers. The case now expects known_edge for the two resolved wrappers. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
javascript/stored-field-callee-shapesin the query-layer suite (tests/run.py, which CI does not run) failed 3 of 18 checks on 0.1.9. Two commits that each passed on their own interact:After both, there are two separate effects:
known_edge. That is the more precise answer the promisify change intended, so those two checks now expectknown_edge.path. An untypedthis.find(), wherefindis a field holding a function, is a site the engine marks as a function-valued callee.path's by-name search matched it first ("WOULD connect … receiver not typed") and returned before the "connection is UNKNOWN" verdict could run. The by-name branch now skips a chain when every site it would bridge is one the engine marked as a function-valued callee, so the unknown verdict answers and names the site.This changes the query layer only; engine rules and the parser are untouched.
Tests (rebased on the current 0.1.9)
stored-field-callee-shapes: 18/18.pathcases:path-crosses-framework-and-bynamepasses 14/14 on each of Python and C#, andpath-crosses-remote-and-bynamepasses 11/11 on Java.tests/run.py --lang javascript: 245/245, against 242/245 before this change.