Repository navigation
test-impact: a test helper is the route, not a test; far tests listed apart - #1845
Merged
swapnilpaliwal-sd merged 1 commit intoOct 2, 2026
Conversation
…tests listed apart - A JavaScript / TypeScript function is never a test by its name (runners collect the callback handed to test()/it()), and a module-level Python test_* function counts only in a module pytest collects: a helper in test/helpers.js or tests/helpers.py was "1 test" in a file no runner collects. - impact marks each test with loads_change: whether its file (or the fixture / conftest files its runner loads) imports the changed file, through the import closure. - test-impact lists first the files that load the change within 3 hops, then "further out" the rest (a key or registration joins them, or the route is long), with its own run command. - imports_fact resolves an ES module import written with its extension and a workspace package's specifier (package.json exports / main); IMPACT_VERSION 63. - The import-time hop no longer fires from the module that merely declares a const asked about: its readers resolve, and every importer's module was listed again (exposed once .js imports resolved). Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 1, 2026 19:44
swapnilpaliwal-sd
deleted the
apps/javascript/test-impact-lists-non-tests-and-far-rout
branch
October 2, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_*function counts only in a module pytest collects, sotest/helpers.jsandtests/helpers.pyno longer show up as "1 test".loads_change: whether its file, or the fixture/conftest files its runner loads, imports the changed file (through the import closure).imports_factnow resolves ESM imports written with their extension and workspace package specifiers. IMPACT_VERSION is 63..jsimports resolved.javascript/a-helper-is-the-route-not-the-test, with a control for a workspace subpath import and a far-hop check.python/conftest-fixtureis extended with a helper and a control.Checked: plugin cases js 307/307, ts 258/258, py 292/292, java 331/331, cs 208/208; engine js 88/88. On a JS monorepo, test-impact for a handler-table module went from 25 files in one list (2 helpers) to 5 near + 22 further out, with no helpers. Probes 68/92 before and after, 0 changed. Edges unchanged (17170).