Repository navigation
build-engines: engines start on a clean machine — static libgomp on Linux, no OpenMP on Windows (#1913) - #1914
Merged
Merged
Conversation
Linux: libgomp links statically for real. -fopenmp on the link line made gcc append its own dynamic -lgomp, so every engine needed libgomp.so.1, which a stock Ubuntu does not have. -fopenmp now compiles only; the link names libgomp.a by path (+ -ldl it needs). Validated on manylinux_2_28 gcc 14: NEEDED is libc/libm/libpthread/libdl/ld-linux only, max GLIBC 2.25, a real index runs on a stock Ubuntu 24.04 with no libgomp1, -j 4 and -j 1 give the same edges. Windows: no /openmp. It links vcomp140.dll (and vcruntime140.dll), absent without the Visual C++ Redistributable; every engine exited 0xC0000135 on a stock Windows Server 2022. Engines are serial on Windows, as through 0.1.8; no .parallel marker. Two new steps fail the build when an engine loads a library a stock system lacks (readelf NEEDED on Linux, dumpbin /dependents on Windows). The engine cache key hashes this file, so no binary built with the old flags is reused. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 10, 2026 22:08
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1913 — release blocker found by the 0.1.9 cross-platform check on clean VMs.
Linux (x64, arm64): every engine needed
libgomp.so.1; on a stock Ubuntu every index failed.-fopenmpon the link line made gcc add a dynamic-lgompdespite-Wl,-Bstatic. Now-fopenmpcompiles only and the link nameslibgomp.aby path (plus-ldl, which it needs).Validated on the workflow's manylinux_2_28 image (gcc 14): NEEDED = libc / libm / libpthread / libdl / ld-linux only, max GLIBC 2.25; a real index runs on a stock Ubuntu 24.04 without libgomp1;
-j 4and-j 1give identical edges on a fixture and a 65-file project.Windows:
/openmplinksvcomp140.dll(+vcruntime140.dll), which Windows lacks without the Visual C++ Redistributable; every engine exited0xC0000135on a stock Windows Server 2022. Engines are built serial on Windows, as in 0.1.8 (no.parallelmarker, so no-j). Parallel on Windows can return with the DLLs shipped app-local, in 0.1.10.Guards: two new steps fail the build if an engine loads a library a stock system lacks (
readelf -dNEEDED on Linux;dumpbin /dependentson Windows). The engine cache key hashes this workflow, so nothing built with the old flags is reused.macOS is unchanged (its engines are built without OpenMP).
Branched from
0.1.9; until the release PR (#1905) merges, the diff also shows the 0.1.9 commits. This PR's own change is one commit to.github/workflows/build-engines.yml.