Skip to content

fix: pin tree-sitter-java to the version tree-sitter-groovy pins, so it stays deduped #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swapnilpaliwal-sd merged 1 commit into from
Sep 18, 2026
Merged

fix: pin tree-sitter-java to the version tree-sitter-groovy pins, so it stays deduped #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions graph/test/tools/package-contents-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,22 @@ const deps=j.dependencies||{}, pdeps=JSON.parse(fs.readFileSync(root+"/parser/pa
Object.keys(deps).length ? ok("runtime dependencies are declared") : bad("package.json declares no runtime dependencies");
for(const k of Object.keys(pdeps)) deps[k] ? ok("dependency hoisted: "+k) : bad("runtime dependency not hoisted from the parser workspace: "+k);

// ---- the native grammar must not be duplicated ----
// tree-sitter-groovy pins tree-sitter-java to an exact version. Asking for a different one
// leaves npm two versions to satisfy and it nests a second copy, whose gyp config resolves
// node-addon-api by a relative path that is wrong once nested -- so it cannot build even
// with a full toolchain, and linux-arm64, which has no prebuilt core and must build, fails
// outright. A caret range is not enough: ^0.23.4 resolves to 0.23.5 and nests again. The two
// have to name the SAME version. See #901.
try{
const groovy=JSON.parse(fs.readFileSync(root+"/node_modules/tree-sitter-groovy/package.json","utf8"));
const want=(groovy.dependencies||{})["tree-sitter-java"];
const have=(JSON.parse(fs.readFileSync(root+"/parser/package.json","utf8")).dependencies||{})["tree-sitter-java"];
if(!want) ok("tree-sitter-groovy no longer depends on tree-sitter-java");
else if(have===want) ok("tree-sitter-java matches the version tree-sitter-groovy pins ("+want+"), so it stays deduped");
else bad("tree-sitter-java is "+have+" but tree-sitter-groovy pins "+want+"; npm will nest a second copy that cannot build (#901)");
}catch(e){ console.log(" skip tree-sitter-groovy not installed; run npm install to assert the pin"); }

// ---- what the tarball would contain ----
let files;
try{
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"tree-sitter": "^0.21.1",
"tree-sitter-c-sharp": "0.23.1",
"tree-sitter-groovy": "^0.1.2",
"tree-sitter-java": "^0.21.0",
"tree-sitter-java": "0.23.4",
"tree-sitter-python": "^0.21.0",
"typescript": "^6.0.0",
"yaml": "^2.8.2"
Expand Down
4 changes: 2 additions & 2 deletions parser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@axiomcode/parser",
"version": "0.1.0",
"description": "AxiomCode Parser \u2014 extracts Java/Python/TypeScript/Gradle/XML/YAML/Properties facts from a codebase.",
"description": "AxiomCode Parser — extracts Java/Python/TypeScript/Gradle/XML/YAML/Properties facts from a codebase.",
"main": "dist/extract.js",
"types": "dist/extract.d.ts",
"scripts": {
Expand All @@ -20,7 +20,7 @@
"tree-sitter": "^0.21.1",
"tree-sitter-c-sharp": "0.23.1",
"tree-sitter-groovy": "^0.1.2",
"tree-sitter-java": "^0.21.0",
"tree-sitter-java": "0.23.4",
"tree-sitter-python": "^0.21.0",
"typescript": "^6.0.0",
"yaml": "^2.8.2"
Expand Down