Skip to content

[http-client-python] Fix grouped parameter attribute access for reserved words #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tadelesh merged 6 commits into from
Apr 15, 2026
Merged

[http-client-python] Fix grouped parameter attribute access for reserved words #3447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1133977
Update dependencies
Apr 15, 2026
2bcecee
Sync shared files from typespec repo (2026-04-15 08:14:49)
Apr 15, 2026
4da7f93
Add changelog
Apr 15, 2026
b63b656
Update dependencies (2026-04-15 08:15:55)
Apr 15, 2026
31ec1f3
Regenerate for typespec-python (2026-04-15 08:21:49)
Apr 15, 2026
6689a0e
Regenerate for autorest.python (2026-04-15 08:35:43)
Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-black-linesep-windows-2026-3-15-13-52-35.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
changeKind: fix
packages:
- "@autorest/python"
- "@azure-tools/typespec-python"
---

Fix grouped parameter attribute access for reserved words in code generation
8 changes: 8 additions & 0 deletions .chronus/changes/python-headersFix-2026-3-9-15-51-55.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
changeKind: fix
packages:
- "@autorest/python"
- "@azure-tools/typespec-python"
---

Pass `headers` kwarg through to next requests in paging calls
8 changes: 8 additions & 0 deletions .chronus/changes/python-incorrectWireNamePadding-2026-3-9-13-17-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
changeKind: fix
packages:
- "@autorest/python"
- "@azure-tools/typespec-python"
---

Fix padding of keys in splatted body parameter method signature
2 changes: 1 addition & 1 deletion packages/autorest.python/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"homepage": "https://github.com/Azure/autorest.python/blob/main/README.md",
"dependencies": {
"@typespec/http-client-python": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNjEyODg2My9hcnRpZmFjdE5hbWUvYnVpbGRfYXJ0aWZhY3RzX3B5dGhvbg2/content?format=file&subPath=%2Fpackages%2Ftypespec-http-client-python-0.28.3.tgz",
"@typespec/http-client-python": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNjE1ODIzMi9hcnRpZmFjdE5hbWUvYnVpbGRfYXJ0aWZhY3RzX3B5dGhvbg2/content?format=file&subPath=%2Fpackages%2Ftypespec-http-client-python-0.28.3.tgz",
"@autorest/system-requirements": "~1.0.2",
"fs-extra": "~11.2.0",
"tsx": "^4.21.0"
Expand Down
2 changes: 1 addition & 1 deletion ...les/specification/directives/generated/azure/directives/sample/_operations/_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def prepare_request(next_link=None):
_request.url = self._client.format_url(_request.url)

else:
_request = HttpRequest("GET", next_link)
_request = HttpRequest("GET", next_link, headers=_headers)
_request.url = self._client.format_url(_request.url)

return _request
Expand Down
2 changes: 1 addition & 1 deletion ...specification/directives/generated/azure/directives/sample/aio/_operations/_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def prepare_request(next_link=None):
_request.url = self._client.format_url(_request.url)

else:
_request = HttpRequest("GET", next_link)
_request = HttpRequest("GET", next_link, headers=_headers)
_request.url = self._client.format_url(_request.url)

return _request
Expand Down
100 changes: 80 additions & 20 deletions .../AcceptanceTests/CustomPollerPager/custompollerpager/aio/operations/_paging_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -200,7 +203,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -271,7 +277,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -342,7 +351,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -422,7 +434,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -494,7 +509,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -583,7 +601,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -731,7 +752,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -808,7 +832,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -897,7 +924,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -989,7 +1019,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1061,7 +1094,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1133,7 +1169,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1204,7 +1243,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1275,7 +1317,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1346,7 +1391,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1653,7 +1701,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1765,7 +1816,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1839,7 +1893,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down Expand Up @@ -1913,7 +1970,10 @@ def prepare_request(next_link=None):
)
_next_request_params["api-version"] = self._config.api_version
_request = HttpRequest(
"GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params
"GET",
urllib.parse.urljoin(next_link, _parsed_next_link.path),
headers=_headers,
params=_next_request_params,
)
_request.url = self._client.format_url(_request.url)
_request.method = "GET"
Expand Down
Loading
Loading