Azure Clean Room: CLI for 2026-04-30-preview#9848
Merged
necusjz merged 3 commits intoAzure:mainfrom May 7, 2026
Merged
Conversation
…ate.CleanRoom patches - Regenerate aaz/ subtree from openapi.json (2026-04-30-preview) - Add 'collaboration get-readonly-kube-config' command - PUT -> PATCH on collaboration/consortium/consortium-view update - Restore PrivateEndpointUtil + rewire URLs through env-var-driven namespace Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…review Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| managedcleanroom collaboration create | cmd managedcleanroom collaboration create added parameter resource_location |
||
| managedcleanroom collaboration enable-workload | cmd managedcleanroom collaboration enable-workload update parameter workload_type: updated property choices from ['analytics'] to ['Analytics'] |
||
| managedcleanroom collaboration get-readonly-kube-config | cmd managedcleanroom collaboration get-readonly-kube-config added |
||
| managedcleanroom collaboration update | cmd managedcleanroom collaboration update added parameter resource_location |
||
| managedcleanroom consortium create | cmd managedcleanroom consortium create added parameter resource_location |
||
| managedcleanroom consortium update | cmd managedcleanroom consortium update added parameter resource_location |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the managedcleanroom Azure CLI extension release (1.0.0b6) and introduces a new generated AAZ command to retrieve a collaboration’s read-only kubeconfig.
Changes:
- Bump extension version to
1.0.0b6and add release notes. - Add
az managedcleanroom collaboration get-readonly-kube-config(AAZ-generated command) and export it from the collaboration command package. - Wire the new command’s mgmt-plane URL through
PrivateEndpointUtil.get_configured_namespace().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/managedcleanroom/setup.py |
Version bump to 1.0.0b6. |
src/managedcleanroom/HISTORY.rst |
Adds 1.0.0b6 release notes describing the update. |
src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_get_readonly_kube_config.py |
Adds the generated AAZ command implementation for fetching the read-only kubeconfig. |
src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/__init__.py |
Exposes the new command via wildcard import. |
| "managedcleanroom collaboration get-readonly-kube-config", | ||
| ) | ||
| class GetReadonlyKubeConfig(AAZCommand): | ||
| """Gets the readonly kubeconfig for the collaboration. |
…apply patches Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kkarmakarMS
reviewed
May 6, 2026
| +++++++ | ||
| * Update commands to reflect new API version 2026-04-30-preview | ||
| * Added: ``az managedcleanroom collaboration get-readonly-kube-config`` to fetch the read-only kubeconfig for a collaboration | ||
| * PUT -> PATCH on ``collaboration update``, ``consortium update``, ``consortium-view update`` |
Contributor
There was a problem hiding this comment.
NIT:
PUT -> PATCH on ``collaboration update``, ``consortium update``, ``consortium-view update``
This is not required. Whenever we auto-generate, it suggests PUT but it should be PATCH, something to fix at the TSP maybe.
kkarmakarMS
approved these changes
May 6, 2026
|
@necusjz can you please take a look at this? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Related to Azure/aaz#1000 |
|
@necusjz thanks, seems like all tests passed. Can you please help merging this ? |
necusjz
approved these changes
May 7, 2026
Collaborator
|
[Release] Update index.json for extension [ managedcleanroom-1.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=163222385&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.