Open
Conversation
xiazhan
reviewed
Mar 25, 2026
xiazhan
reviewed
Mar 26, 2026
ruinan-liu
commented
Mar 26, 2026
Collaborator
Author
ruinan-liu
left a comment
There was a problem hiding this comment.
Reply to comments
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
xiazhan
reviewed
Mar 31, 2026
ruinan-liu
commented
Mar 31, 2026
Collaborator
Author
ruinan-liu
left a comment
There was a problem hiding this comment.
Replied to comments
xiazhan
reviewed
Apr 1, 2026
ruinan-liu
commented
Apr 1, 2026
Collaborator
Author
ruinan-liu
left a comment
There was a problem hiding this comment.
Respond to comment
ruinan-liu
commented
Apr 2, 2026
xiazhan
reviewed
Apr 3, 2026
Collaborator
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
Author
|
xiazhan
reviewed
Apr 4, 2026
|
|
||
| func (c *Controller) shouldFailOpen(resource *resource.Resource) bool { | ||
| func (c *Controller) shouldFailOpen(snap *resource.Snapshot, resource *resource.Resource) bool { | ||
| if snap != nil && snap.Deleted() && snap.ForegroundDeletion { |
Collaborator
There was a problem hiding this comment.
It means ForegroundDeletion and FailOpen cannot co-exist in deleting scenario.
Good thing is that FailOpen currently is only used on reconciler level by overlay-eno-reconciler and ForegroundDeletion is not used yet.
xiazhan
reviewed
Apr 4, 2026
| } | ||
|
|
||
| // Orphaned or disabled resources should be reflected as deleted | ||
| if snap.Deleted() && (snap.Orphan || snap.Disable || failingOpen) { |
Collaborator
There was a problem hiding this comment.
How about ForgroundDeletion && faillingOpen case?
xiazhan
reviewed
Apr 4, 2026
| // Foreground deletion requires the resoruce to be fully removed before reporting deleted | ||
| // if snap.Deleted() && failingOpen && !snap.ForegroundDeletion { | ||
| // return true | ||
| // } |
Collaborator
There was a problem hiding this comment.
Why is it commented out? It looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses
dependsOnto add inter composition ordering