Conversation
microsoft-github-policy-service
Bot
added
the
emitter:python
Collaborator
|
All changed packages have been documented.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
commit: |
Collaborator
|
You can try these changes here
|
Contributor
⚡ Benchmark ResultsComparing [
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce duplication between
typespec-python(a thin wrapper) and upstream@typespec/http-client-pythonso we don't keep maintaining two copies of the same eng/test scaffolding by hand.Approach
eng/scripts/sync.ts— new allow-list mirror that copies a curated set of shared files from a sibling checkout (<repo-root>/core/packages/http-client-python/) into this package. Supports--checkfor CI drift detection.eng/scripts/ci/regenerate-common.ts— shared helpers / spec tables /prepareBaselineOfGeneratedCode, byte-identical with the upstream copy. Synced.eng/scripts/ci/regenerate.ts— kept per-repo: wrapper does single-phase in-process regen; upstream does two-phase. Imports common helpers, owns only paths/argv/orchestration.dev_requirements.txt— synced as a section (everything before the# additional dependency needed for developmentmarker is replaced from upstream; wrapper-only deps likesetuptoolsare preserved).run_apiview.py,run_mypy.py,run_pylint.py,run_pyright.py,run_sphinx_build.py,util.py, plusmypy.ini,pylintrc,pyrightconfig.json.tests/data/,tests/mock_api/,tests/requirements/,tests/conftest.py,tests/install_packages.py,tests/tox.ini, and thegenerator/(pygen) tree.eng/scripts/setup/*is intentionally not synced — the wrapper owns its own setup pipeline (install.py,prepare.py,venvtools.py, …)..gitignoreupdated so synced directories (mirrored on demand bypnpm sync) start empty in fresh checkouts.Result
Most engineering files now have a single upstream source of truth; wrapper-specific divergence is limited to the orchestrator (
regenerate.ts), the setup scripts, and the small wrapper-only tail ofdev_requirements.txt. CI keeps everything honest viapnpm sync --check.