Fix: Add null checks for Overlay.Animator in GraphicsSingleton.OnRender#11
Open
prjanitor wants to merge 2 commits intoBOLL7708:masterfrom
Open
Conversation
Add null checks for Overlay and Overlay.Animator before dereferencing in both foreach loops within the OnRender method. This prevents NullReferenceException when an overlay is added with a null Animator or if the Animator property is null due to initialization failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
GraphicsSingleton.OnRender, the code iterates throughSession.Overlays.Valuesand directly accessesoverlay.Animatorwithout verifying that theOverlayobject or itsAnimatorproperty is non-null. This causes aNullReferenceExceptionat runtime if:Overlayis added to the dictionary with a nullAnimatorAnimatorproperty is null due to initialization failureSolution
Added null checks at the beginning of both
foreachloops in theOnRendermethod:This safely skips any overlay that is null or has a null animator, preventing the exception while maintaining the rendering pipeline's functionality for valid overlays.
Files Changed
OpenVROverlayPipe/GraphicsSingleton.cs- Added null checks in two foreach loops withinOnRendermethodThis PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.