Repository navigation
[codex] Treat data-receiving WHOOP backfills as partial success - #10
Merged
Merged
Conversation
BarMal
marked this pull request as ready for review
June 20, 2026 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest on-device backfill screenshot shows the strap is now sending historical data (
150history frames,3batches,1done), but the service still leaves the UI inConnection failed.This PR fixes the service-level outcome handling for that case.
What changed
WhoopRuntimeState.ERROR.Connection failed.Why
The BLE/debug counters prove data can arrive and completion can be observed even when a later cleanup/timeout path throws. In that case, marking the whole run as failed hides the useful result and leaves the debug screen red despite actual historical progress.
Validation
./gradlew.bat :app:assembleDebug./gradlew.bat testDebugUnitTest