Ensure balanced calls to openElem/closeElem in CsvBuilder#2657
Merged
ChristianGruen merged 1 commit intoBaseXdb:mainfrom Apr 30, 2026
Merged
Ensure balanced calls to openElem/closeElem in CsvBuilder#2657ChristianGruen merged 1 commit intoBaseXdb:mainfrom
openElem/closeElem in CsvBuilder#2657ChristianGruen merged 1 commit intoBaseXdb:mainfrom
Conversation
ChristianGruen
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For empty rows,
CsvBuilderfailed to issuecloseElemfor the<record>element to the underlying databaseBuilder. This left one or more elements open, so when the document was closed,closeDocleft the document with its preliminary size of 0. When walking through a document with size 0, the size never advances while allocating resources, causing the OOM.The fix is to make sure
closeElemis always called for<record>, even when the row is empty.