fix: restore Device Settings section in settings sidebar#5993
Open
fix: restore Device Settings section in settings sidebar#5993
Conversation
Contributor
Greptile SummaryThis PR restores the Device Settings section that was accidentally dropped in commit
No logic changes were introduced; this is a pure restoration of previously working code. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant N as NotificationCenter
participant DHV as DesktopHomeView
participant SSB as SettingsSidebar
participant SCV as SettingsContentView
participant DSP as DeviceSettingsPage
N->>DHV: .navigateToDeviceSettings
DHV->>DHV: selectedSettingsSection = .device
DHV->>DHV: selectedIndex = settings (animated)
DHV->>SSB: render with selectedSection = .device
SSB->>SSB: highlight Device row (wave.3.right.circle icon)
DHV->>SCV: render selectedSection = .device
SCV->>DSP: DeviceSettingsPage()
DSP-->>SCV: BLE scan / pair UI
Reviews (1): Last reviewed commit: "fix: restore Device Settings section in ..." | Re-trigger Greptile |
1bbc10f to
c4565af
Compare
c4565af to
32f18a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the Device Settings section that was accidentally removed in commit badf72b ("Flatten Advanced settings").
Changes
case device = "Device"back toSettingsSectionenumDeviceSettingsPage()to the settings content switchselectedSettingsSection = .devicein thenavigateToDeviceSettingshandlerSettingsSidebarImpact
Users can now access Device Settings to pair BLE devices. This was a P1 regression — without this, there was no UI path to scan/pair Omi hardware on macOS.
Fixes #5917