Skip to content

refactor(abstract-utxo): import descriptor types directly from @bitgo/wasm-utxo#8862

Merged
OttoAllmendinger merged 1 commit into
masterfrom
otto/descriptor-types-from-wasm
May 26, 2026
Merged

refactor(abstract-utxo): import descriptor types directly from @bitgo/wasm-utxo#8862
OttoAllmendinger merged 1 commit into
masterfrom
otto/descriptor-types-from-wasm

Conversation

@OttoAllmendinger
Copy link
Copy Markdown
Contributor

Summary

Drops the `DescriptorMap`, `SignerKey`, and `sumValues` re-exports/wrappers from `wasmUtil.ts` by importing the underlying types directly from `@bitgo/wasm-utxo` in:

  • `src/descriptor/{descriptorWallet,index,validatePolicy}.ts` — `DescriptorMap` now sourced from `descriptorWallet.DescriptorMap`
  • `src/transaction/descriptor/{explainPsbt,index,signPsbt}.ts` — same plus `SignerKey` typed as `Parameters[1]` locally; trivial `sumValues` inlined

No behavior change — just removes a redundant indirection layer.

PR group context

Part of an 8-PR fan-out removing `@bitgo/utxo-lib` from abstract-utxo runtime. Independent — file-disjoint from the other PRs in this group. Can merge in any order.

Test plan

  • `yarn tsc --noEmit` clean in `modules/abstract-utxo`
  • `yarn lint` clean in `modules/abstract-utxo`

🤖 Generated with Claude Code

…wasmUtil

Move the DescriptorMap type alias to descriptor/index.ts (the natural
location), inline SignerKey at its single call site, and inline the
sumValues one-liner at the two explainPsbt/parse call sites.

Refs: T1-3279
@OttoAllmendinger OttoAllmendinger requested a review from a team as a code owner May 26, 2026 09:13
@OttoAllmendinger OttoAllmendinger merged commit 0b8eec5 into master May 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants