feat: fixed verify transaction flow for tao and polyx#8883
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Substrate-based coin transaction verification so TAO and POLYX transfers/sweeps are validated against the intended recipient (address, and amount for non-sweep transfers), and adds unit tests covering the expected success and failure cases.
Changes:
- Strengthen
verifyTransactionin the Substrate base implementation to validate recipient address/amount and add missing parameter guards. - Add TAO unit tests for
verifyTransactioncovering transfer, sweep, and guard/error cases. - Add POLYX unit tests for
verifyTransactioncovering transfer and guard/error cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/abstract-substrate/src/abstractSubstrateCoin.ts | Implements recipient/amount verification for Substrate transfers and introduces guard checks for required prebuild params. |
| modules/sdk-coin-tao/test/unit/tao.ts | Adds verifyTransaction unit coverage for TAO transfer and sweep flows plus guard cases. |
| modules/sdk-coin-polyx/test/unit/polyx.ts | Adds verifyTransaction unit coverage for POLYX transfer flow plus guard cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nvrakesh06
previously approved these changes
May 29, 2026
ticket: CECHO-991 Signed-off-by: B.Prasad <bhaveshprasad584@bitgo.com>
nvrakesh06
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket: CECHO-991