feat(sdk-core): add webauthnInfo param to AddKeychainOptions for atom…#8888
Merged
Merged
Conversation
…ic passkey attachment The backend POST /api/v2/:coin/key handler reads `req.body.webauthnInfo` (single object) to atomically attach a passkey during key creation, but the SDK only sent `webauthnDevices` (array) which the backend ignores. This caused passkey attachment to require a separate best-effort PUT call that could fail, leaving wallets in an inconsistent state. Add `webauthnInfo` field to `AddKeychainOptions` and pass it through in `keychains.add()` so callers can atomically link a passkey to a keychain during creation. Deprecate `webauthnDevices` on `AddKeychainOptions` since the backend never reads it on the POST path. WCN-127
mukeshsp
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend POST /api/v2/:coin/key handler reads
req.body.webauthnInfo(single object) to atomically attach a passkey during key creation, but the SDK only sentwebauthnDevices(array) which the backend ignores. This caused passkey attachment to require a separate best-effort PUT call that could fail, leaving wallets in an inconsistent state.Add
webauthnInfofield toAddKeychainOptionsand pass it through inkeychains.add()so callers can atomically link a passkey to a keychain during creation.Deprecate
webauthnDevicesonAddKeychainOptionssince the backend never reads it on the POST path.WCN-127