Conversation
TSS signing relies on txPrebuild.buildParams to carry SDK transaction intent into signing. Some presign hooks replace txPrebuild and can drop that metadata before TSS verification. - Restore buildParams after TSS presign when the presigned prebuild omits them. - Add a wallet unit test covering a presign hook that replaces txPrebuild. Ticket: WCI-505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve
txPrebuild.buildParamsacross TSS presign flows insdk-core.Some coin level
presignTransactionimplementations can replacetxPrebuildbefore TSS signing. For TSS wallets,buildParamscarries SDK-local transaction intent metadata such as recipients and transaction type. If that metadata is dropped, downstream TSS signing and verification can receive empty or missingtxParams, causing transaction verification failures.This was observed in the
EdDSA MPCv2Solana signing path. Solana’s presign flow can refresh thetxPrebuildfrom the tx request and drop SDK-localbuildParams. EdDSA MPCv2 then performs TSS signing with those missing params, which can cause recipient verification to fail before the transaction reaches the intended signing path.This change restores the original
txPrebuild.buildParamsafter presign when the presigned TSS prebuild omits them.Issue Number
WCI-505
Type of change