test: add integration test for generateWallet#212
Open
pranishnepal wants to merge 1 commit into
Open
Conversation
pranishnepal
commented
May 29, 2026
| return new Promise((resolve, reject) => { | ||
| server.once('error', reject); | ||
| server.listen(0, '127.0.0.1', () => { | ||
| server.listen(0, LOCALHOST, () => { |
Contributor
Author
There was a problem hiding this comment.
0 here means use whatever port is available!
bdesoky
reviewed
May 29, 2026
| ); | ||
|
|
||
| res.status.should.equal(200); | ||
| const body = (await res.json()) as any; |
There was a problem hiding this comment.
small nit: can we use a better type than any here?
Contributor
Author
There was a problem hiding this comment.
Ah, good point -- there was no exported type and since this was test, i just let it be any, but i added it now. Thank you!
This PR adds an integration test for the generateWallet endpoint, which is responsible for generating a new wallet with the provided parameters. The test verifies that the endpoint correctly generates keys using the key provider and creates a wallet on BitGo with the expected properties -- tests cover both local and external key generation modes. Ticket: WAL-1502
bdesoky
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds an integration test for the generateWallet endpoint, which is responsible for generating a new wallet with the provided parameters. The test verifies that the endpoint correctly generates keys
using the key provider and creates a wallet on BitGo with the expected
properties -- tests cover both local and external key generation modes.
Ticket: WAL-1502
Testing
npm run test:integrationnpm run docker:test:integrationNext Steps
Add the test to CI & Add test for other flows