fix: use trap for cleanup in run-integration-tests.sh#213
Merged
Conversation
Replace || true pattern with trap 'docker-compose down' EXIT so cleanup always runs on exit while preserving the real exit code. Ticket: WCN-399
pranishnepal
force-pushed
the
follow-up/WCN-399
branch
from
4a61102 to
a193c63
Compare
danielpeng1
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace || true pattern with trap 'docker-compose down' EXIT so cleanup always runs on exit while preserving the real exit code. The previous approach always captured exit code 0 due to || true, meaning CI would never go red on test failures.