test: add sendMany integration tests: btc and eth#217
Merged
Conversation
Adds four end-to-end sendMany integration tests covering the 2×2 matrix of coin (tbtc, hteth) × signing mode (local, external). External signing tests validate that AWM correctly delegates to the key provider — POST /sign is called with the raw PSBT for BTC, and with an operationHash for ETH. Local signing tests seed the mock key provider with a deterministic xprv so AWM can retrieve it via GET /key/:pub and sign the PSBT using coin.signTransaction() internally. Ticket: WCN-680
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "height": 800000 | |||
Contributor
There was a problem hiding this comment.
nit - i'd like for this to represent more complete block data. even if all that's required is height a full btc block might be nice here
Contributor
Author
There was a problem hiding this comment.
will look into that
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "transfer": { | |||
Contributor
There was a problem hiding this comment.
same for the transfers, something that looks a bit more like our full transfer object might be nice
margueriteblair
approved these changes
Jun 2, 2026
Contributor
margueriteblair
left a comment
margueriteblair
left a comment
There was a problem hiding this comment.
looks good, had some nits but those can be done in follow up
danielpeng1
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds end-to-end sendMany integration tests covering the 2×2 matrix of coin (tbtc, hteth) × signing mode (local, external).
External signing tests validate that AWM correctly delegates to the key provider: POST
/signis called with the raw PSBT for BTC, and with an operationHash for ETH.Local signing tests seed the mock key provider with a deterministic xprv so AWM can retrieve it via
GET /key/:puband sign the PSBT usingcoin.signTransaction()internally.Ticket: WCN-680
Testing
Purely a test setup, verified with
npm run docker:test:integration+ this CI