Repository navigation
fix: remediate server and gateway dependency advisories - #106
Open
sweetcornna wants to merge 2 commits into
Open
sweetcornna wants to merge 2 commits into
sweetcornna wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the dependency closure used by
@dormice/server,@dormice/gateway, and@dormice/sharedto versions that fix the public advisories currently reported for those services. This keeps the existing pinned source, 24-hour release-age gate, and build-script allowlist. No sandbox/network policy changes, application credentials, runtime artifacts, or RegForge-specific code are included.Dependency changes
@fastify/static10.1.2 (its plugin metadata supports Fastify 5.x), busboy 3.2.2, and the affected glob 13 range to 14.0.2.@grpc/grpc-js1.14.5.Representative advisories: Fastify header validation, static route authorization, Undici TLS validation, Zod, fast-uri.
Test portability correction
The upgrade dial-timeout test assumed that TEST-NET-1 cannot accept a TCP connection. On this host, a network intermediary accepts that dial in 6 ms, then closes it; the handshake has already been replayed, so the correct production behavior is not to inject a 502 into an upgraded stream. The test now models a pending dial without external I/O, asserts the 500 ms connect deadline, and retains the 502/body/elapsed-time checks. Production forwarding behavior is unchanged.
Validation
pnpm install --filter @dormice/server... --filter @dormice/gateway... --frozen-lockfiletsc --noEmitpass.pnpm audit --json, evaluated against the exact importers/snapshots transitive closure: 0 reported advisories for 223 production dependency versions, and 0 for 320 versions including these packages' development dependencies. Matching uses package+version, not the representative path in an audit finding, because a shared dependency may be reported under a different workspace.Scope limitation: the complete monorepo lockfile still reports findings in other workspaces (for example the website/console). This PR does not claim a clean whole-repository audit or a complete security certification; those unrelated upgrade paths need separate compatibility work. The first gateway run failed due to the external TEST-NET assumption described above; it was not silently counted as a pass.