Skip to content

fix: remediate server and gateway dependency advisories - #106

Open
sweetcornna wants to merge 2 commits into
mainfrom
fix/runtime-dependency-advisories-20261111
Open

sweetcornna wants to merge 2 commits into
mainfrom
fix/runtime-dependency-advisories-20261111

Conversation

@sweetcornna

Copy link
Copy Markdown
Collaborator

Summary

Update the dependency closure used by @dormice/server, @dormice/gateway, and @dormice/shared to versions that fix the public advisories currently reported for those services. This keeps the existing pinned source, 24-hour release-age gate, and build-script allowlist. No sandbox/network policy changes, application credentials, runtime artifacts, or RegForge-specific code are included.

Dependency changes

  • Fastify 5.12.6 and find-my-way 9.7.0; fast-uri 3.1.9.
  • @fastify/static 10.1.2 (its plugin metadata supports Fastify 5.x), busboy 3.2.2, and the affected glob 13 range to 14.0.2.
  • Undici 8.12.2 and @grpc/grpc-js 1.14.5.
  • Zod 4.6.6 in the three service/shared manifests, rather than overriding unrelated Zod 3 consumers.
  • The deprecated esbuild-kit/core-utils build dependency uses esbuild 0.28.2 instead of the vulnerable 0.18 line.

Representative advisories: Fastify header validation, static route authorization, Undici TLS validation, Zod, fast-uri.

Test portability correction

The upgrade dial-timeout test assumed that TEST-NET-1 cannot accept a TCP connection. On this host, a network intermediary accepts that dial in 6 ms, then closes it; the handshake has already been replayed, so the correct production behavior is not to inject a 502 into an upgraded stream. The test now models a pending dial without external I/O, asserts the 500 ms connect deadline, and retains the 502/body/elapsed-time checks. Production forwarding behavior is unchanged.

Validation

  • pnpm install --filter @dormice/server... --filter @dormice/gateway... --frozen-lockfile
  • Shared, server, gateway: builds and tsc --noEmit pass.
  • Server: 663 passed, 2 skipped (38 test files passed, one skipped).
  • Gateway: 241 passed, 20 test files passed. The focused forwarding suite is 19 passed.
  • pnpm audit --json, evaluated against the exact importers/snapshots transitive closure: 0 reported advisories for 223 production dependency versions, and 0 for 320 versions including these packages' development dependencies. Matching uses package+version, not the representative path in an audit finding, because a shared dependency may be reported under a different workspace.
  • A separate controlled Linux/WSL integration of the updated service dependencies passed 11 persistent-data/network/recovery checks. No real account data was used.

Scope limitation: the complete monorepo lockfile still reports findings in other workspaces (for example the website/console). This PR does not claim a clean whole-repository audit or a complete security certification; those unrelated upgrade paths need separate compatibility work. The first gateway run failed due to the external TEST-NET assumption described above; it was not silently counted as a pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant