Repository navigation
CI validation (draft): make seconv atomic writes fail closed - #169
Closed
Blackspirits wants to merge 2 commits into
Closed
Blackspirits wants to merge 2 commits into
Blackspirits wants to merge 2 commits into
Conversation
Owner
Author
|
Superseded by fork-local CI validation PR #170, based on a newer upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI validation draft — do not merge.
When a same-directory staging file cannot be created,
AtomicFileWritercurrently falls back to truncating the destination (FileMode.Create). If subsequent serialization or process execution fails, the original subtitle is lost.This change rejects the save instead, preserving the original file and its atomic-write guarantee. Adds deterministic failure-injection regression tests for I/O errors and denied permissions.
Trade-off: saves can now fail when the output directory is not writable even if the destination itself can be overwritten; this is intentional to prioritize data integrity. File-opening behavior, symbolic link resolution and successful saves remain unchanged.
Validation: diff inspected; automated build/tests pending. Independent review and platform-specific checks not completed. No upstream submission or merge is authorized.