Skip to content

Implement chipStar support#3

Open
pvelesko wants to merge 828 commits intomainfrom
chipStar
Open

Implement chipStar support#3
pvelesko wants to merge 828 commits intomainfrom
chipStar

Conversation

@pvelesko
Copy link
Copy Markdown
Collaborator

No description provided.

jeremylt and others added 30 commits May 19, 2025 15:07
rust - update rust examples to match c/python
Use HTML comments as doc inclusion markers
Add ncomp=4 as common CPU restriction variant
Co-authored-by: Peter Munch <peterrmuench@gmail.com>
ex - use deal.II fe to build libCEED Basis
cpu - remove vectorize warnings for Clang -O3
* doc - improve internal API documentation

* doc - clarify delegation

* doc - update wording for clarity

Co-authored-by: James Wright <james@jameswright.xyz>

* doc - clarify memcheck==valgrind

* doc - clarify shared gpu backends

* doc - clarify l/e/q-vecs

* doc - clarify occa backend status

* doc - more inheritance clarification

* doc - minor claification to QF fields

* minor - remove unneeded variables

* doc - update inheritance language

* doc - update shared description

* doc - more gpu notes

* doc - update fallback description

* doc - clarify fallback is only for pc support

* doc - minor updates to user facing GPU section

* doc - minor reordering of major sections

---------

Co-authored-by: James Wright <james@jameswright.xyz>
cuda-12.9 contains anonymous unions, which are not in c99. But c11 is
widely supported these days so it seems fair to update.

One nit is that c11 does not require VLA, and libCEED uses VLA-pointers
internally for some purposes.
…ndling

This has warnings about strncpy (vs strncpy_s) and fprintf (vs fprintf_s).
* ci: noether CUDA_DIR=/usr/local/cuda-12.9
* makefiles: update defaults from c99 to c11
* tidy: -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling
* ci: noether rocm-6.3
* cuda - AtPoints diagonal assembly for gen

* hip - AtPoints diagonal assembly for gen

* pc - use subops for LinearAssemble[Add]Diagonal if composite

* gen - turn more numbers into named variables

* gen - fix alignment for assembly

* gen - check for only one active basis in/out

* HIP gen at points syntax error fixes

* hip - embarassing fix

* gen - add Tab helper to manage indentation

---------

Co-authored-by: Zach Atkins <Zach.Atkins@colorado.edu>
jeremylt and others added 7 commits March 13, 2026 09:10
* contributing - draft LLM statement

* contributing - deleniate permitted and disallowed LLM usage

* contributing - grammar

Co-authored-by: Valeria Barra <39932030+valeriabarra@users.noreply.github.com>

* dev - add PR template

* contributing - wording consistency between PR template and CONTRIBUTING.md

* minor - typo

* contributing - refrence sf dora

* minor - fix spelling

Co-authored-by: Yohann <dudouit1@llnl.gov>

---------

Co-authored-by: Valeria Barra <39932030+valeriabarra@users.noreply.github.com>
Co-authored-by: Yohann <dudouit1@llnl.gov>
rust - allow setting ceed OPT flags for rust, mostly for CI/cov
@pvelesko pvelesko force-pushed the chipStar branch 2 times, most recently from d2d8709 to a65eb92 Compare March 18, 2026 06:36
* cov - more minor fixes

* rust - clearer exporting of CARGO_CEED_OPT_FLAGS

* tidy - small fixes

* cov - update codecov settings

* ci - remove extra cleans

* ci - need to clean after running asan

* cov - more small fixes

* ci - don't upload reports with no events

* ci - exclude non-rust source from cov in rust job

* ci - rust don't upload on macos

* ci - update action versions

* ci - rust exclude folders on codecov action
Clear CPU QF input buffers before QF assembly
@pvelesko pvelesko force-pushed the chipStar branch 4 times, most recently from 85c856e to ad0af6e Compare April 13, 2026 10:13
jeremylt and others added 3 commits April 15, 2026 09:29
* gpu - pad out elem loop for shared/gen

* typo - fix bad copypasta

Co-authored-by: Zach Atkins <zach.atkins@colorado.edu>

* cuda - don't padd threads on CUDA

* hip - fix element loop bound

* hip - set Chipstar modifications off by default

* hip - comment on logic

* hip - move chipstar jit macro definition

---------

Co-authored-by: Zach Atkins <zach.atkins@colorado.edu>
Don't use JiT options that chipStar cannot process
- Detect chipStar via hipconfig and set HIP_LIB_NAME=CHIP
- Filter clang-only flags from HIPCONFIG_CPPFLAGS for gcc-compiled sources
- Support separate HIPBLAS_DIR for chipStar (hipblas is a separate install)
- Use SYCLCXX as linker when SYCL backends are enabled
- Skip AMD-specific HIPRTC flags on chipStar; pass only -DCEED_RUNNING_JIT_PASS=1
- Add explicit #include <cstring> in hip-gen for chipStar header compat
@pvelesko pvelesko force-pushed the chipStar branch 2 times, most recently from 60c5f6f to e85e3fb Compare April 19, 2026 11:39
Explain that the HIP backends can also run on non-AMD GPUs via chipStar
(SPIR-V over Level Zero/OpenCL), how to point the build at a chipStar
install via HIP_DIR, and which CHIP_* runtime environment variables
select the backend and device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.