updating picomatch#112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4756
What Does This PR Do?
Upgrades picomatch to resolve snyk vulnerability
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
Run npm ls picomatch and yarn list picomatch, confirm you see 4.0.4
Run yarn test or npm test, confirm all tests pass. Ensure yarn build or npm build runs successfully, but you may encounter issues with yarn build:types (will be a follow-on story).
If having issues with any of these, make sure to remove node_modules and yarn.lock and ensure you have .bluebutton-config.json in src folder.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team security engineer's approval.