Skip to content

window: match locale page directories exactly - #304

Open
Rockykln wants to merge 1 commit into
CachyOS:developfrom
Rockykln:fix-locale-pages-prefix
Open

Rockykln wants to merge 1 commit into
CachyOS:developfrom
Rockykln:fix-locale-pages-prefix

Conversation

@Rockykln

Copy link
Copy Markdown

The page lookup used pages/{locale} as prefix, so for de it also matched pages/de-DE/ and every page was added to the stack twice. On startup with a German locale this logs:

Gtk-WARNING: Duplicate child name in GtkStack: involvedpage
Gtk-WARNING: Duplicate child name in GtkStack: readmepage

Matching pages/{locale}/ instead fixes it, for both the initial load and the language switch.

Side note: data/pages/de-DE is identical to data/pages/de and is never selected, since there is no i18n/de-DE. Happy to remove it in a follow-up if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant