Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tweak's package is missing, Hello runs
pacman -S <pkg>in a terminal and treats the tweak as enabled ifrun_cmd_terminalreturns true. But the command ends withread -p 'Press enter to exit', so the exit status is never pacman's. If you cancel the install (close pkexec, answer "n" or close the window), the checkbox stays checked and Hello tries to enable a unit that doesn't exist.Someone hit this on the forum: https://discuss.cachyos.org/t/5369 (post 12).
This checks whether the package is actually installed once the terminal closes. If not, the checkbox gets reset and the existing "Package '…' has not been installed!" message shows up.
Tested with a local build where one tweak pointed to a package that doesn't exist: cancelling the install now unchecks the box and shows the message.