Repository navigation
Rework series, Tier B-01, Minor cleanup of utils added for zshooter - #34
Open
Yashvi-Sharma wants to merge 3 commits into
Open
Yashvi-Sharma wants to merge 3 commits into
Yashvi-Sharma wants to merge 3 commits into
Conversation
get_observation_info_from_cmds wrapped a single from_currsys call in a bare except, so a missing !OBS coordinate key and a genuine failure were handled identically. from_currsys raises ValueError when a bang-key is absent; catch only that. Anything else now propagates instead of being flattened to None and resurfacing as a misleading "No valid target coordinates provided". get_next_moon and _get_next_moon_cached had no live callers; their only call site has been commented out since it was written. The cache was also keyed to the calendar day while calling Time.now() inside the cached body, so it could return a result up to 24h stale, and it raised when location_key was None despite that being the default. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR in the rework series (with Claude's help) to enhance isolability for upstreaming. Each rework branch includes a markdown detailing the rationale and scope of the changes.
Starting with first of the Tier B changes (Tier B: moderate rework, no architectural changes, maybe needs API discussion).
Please refer to the included .md for a summary of the changes.