Repository navigation
Rework series, Tier B-07, moffat kernel tests only - #39
Open
Yashvi-Sharma wants to merge 3 commits into
Open
Yashvi-Sharma wants to merge 3 commits into
Yashvi-Sharma wants to merge 3 commits into
Conversation
moffat_cell_integrals and fwhm2gamma are pure functions with no upstream counterpart, and were covered only transitively through MoffatPSF.get_kernel, so an error in the closed-form integral could only surface as a slightly wrong PSF. The cell integral now checks against scipy's dblquad on individual cells, where it agrees to machine precision, plus normalisation over a wide grid, symmetry, and the uniform averaging over sampled wavelengths that happens inside this function rather than in get_kernel. One case covers a profile far narrower than the cell, which is what the analytic integral exists to handle and what point sampling of the kernel would get wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.