Skip to content

Rework series, Tier B-07, moffat kernel tests only - #39

Open
Yashvi-Sharma wants to merge 3 commits into
mainfrom
rework/tb-07-moffat-kernel-tests
Open

Yashvi-Sharma wants to merge 3 commits into
mainfrom
rework/tb-07-moffat-kernel-tests

Conversation

@Yashvi-Sharma

Copy link
Copy Markdown
Collaborator

No description provided.

Yashvi-Sharma and others added 3 commits November 9, 2026 16:07
moffat_cell_integrals and fwhm2gamma are pure functions with no upstream
counterpart, and were covered only transitively through MoffatPSF.get_kernel,
so an error in the closed-form integral could only surface as a slightly wrong
PSF.

The cell integral now checks against scipy's dblquad on individual cells,
where it agrees to machine precision, plus normalisation over a wide grid,
symmetry, and the uniform averaging over sampled wavelengths that happens
inside this function rather than in get_kernel. One case covers a profile far
narrower than the cell, which is what the analytic integral exists to handle
and what point sampling of the kernel would get wrong.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant