Skip to content

fix failure in fw location for Astier one-param fit - #34

Merged
weatherhead99 merged 4 commits into
mainfrom
PTC_fitting_fwloc_fix
Nov 11, 2026
Merged

weatherhead99 merged 4 commits into
mainfrom
PTC_fitting_fwloc_fix

Conversation

@weatherhead99

Copy link
Copy Markdown
Contributor

fix failure in fw location for Astier one-param fit, and add support for unc.UFloat columns with no units

Yashvi-Sharma
Yashvi-Sharma previously approved these changes Oct 21, 2026

@Yashvi-Sharma Yashvi-Sharma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/eregion/utils/io_utils.py Resolved
Comment thread src/eregion/utils/io_utils.py Resolved
Comment thread src/eregion/utils/io_utils.py Resolved
@weatherhead99

Copy link
Copy Markdown
Contributor Author

@prkrtg any chance of a review on this? I'm using this fix branch in current DEIMOS_PSR analysis so it would be nice to include it in point release for that.

@prkrtg prkrtg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for addressing the comments

@weatherhead99
weatherhead99 merged commit dc04e8a into main Nov 11, 2026
4 checks passed
@weatherhead99
weatherhead99 deleted the PTC_fitting_fwloc_fix branch November 11, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants