Repository navigation
Conversation
UintNumberType.fromJson used parseInt, so "10abc" became 10. Require the whole string to be digits before converting.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UintNumberType.fromJsonparsed strings withparseInt, which stops at the first non-digit.fromJson("10abc")returned10. A uint JSON string now has to be all digits before it is converted.UintBigintType.fromJsonalready usesBigInt, which throws on that string.Test plan
Trailing junk - fromJsonfailed on master (expected [Function] to throw an error) and passes herepnpm --dir packages/ssz exec vitest run test/unit/byType/uint(101 tests OK)Made with Cursor