Skip to content

Migrate LastUsedScanSettings and AppSettings from DataStore to Room #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chrisimx merged 1 commit into from
Aug 8, 2026
Merged

Migrate LastUsedScanSettings and AppSettings from DataStore to Room #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 0 additions & 142 deletions androidApp/src/androidTest/java/io/github/chrisimx/scanbridge/ScanBridgeNavHost.kt
View file
Open in desktop

This file was deleted.

26 changes: 4 additions & 22 deletions androidApp/src/androidTest/java/io/github/chrisimx/scanbridge/ScanBridgeTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,12 @@ import androidx.test.espresso.Espresso.pressBack
import androidx.test.platform.app.InstrumentationRegistry
import androidx.test.rule.GrantPermissionRule
import io.github.chrisimx.esclmockserver.EsclMockServer
import io.github.chrisimx.scanbridge.datastore.appSettingsStore
import io.github.chrisimx.scanbridge.datastore.lastRouteStore
import io.github.chrisimx.scanbridge.datastore.shownMessagesStore
import io.github.chrisimx.scanbridge.datastore.updateSettings
import io.github.chrisimx.scanbridge.proto.copy
import kotlinx.coroutines.runBlocking
import io.github.chrisimx.scanbridge.db.ScanBridgeDb
import org.junit.After
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.koin.mp.KoinPlatform.getKoin

class ScanBridgeTest {
@get:Rule
Expand All @@ -37,22 +33,8 @@ class ScanBridgeTest {
@Before
@After
fun cleanupForTest() {
runBlocking {
composeTestRule.activity.shownMessagesStore.updateData {
it.copy {
thankPlayOne = true
}
}
composeTestRule.activity.lastRouteStore.updateData {
it.copy {
clearLastRoute()
}
}
composeTestRule.activity.appSettingsStore.updateSettings {
clearLastUsedScanSettings()
autoCleanup = true
}
}
val scanBridgeDb: ScanBridgeDb = getKoin().get()
scanBridgeDb.clearAllTables()
}

@Test
Expand Down
26 changes: 4 additions & 22 deletions ...src/androidTest/java/io/github/chrisimx/scanbridge/screenshot/ScanBridgeScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,11 @@ import androidx.test.rule.GrantPermissionRule
import io.github.chrisimx.esclmockserver.EsclMockServer
import io.github.chrisimx.scanbridge.BuildConfig
import io.github.chrisimx.scanbridge.MainActivity
import io.github.chrisimx.scanbridge.datastore.appSettingsStore
import io.github.chrisimx.scanbridge.datastore.lastRouteStore
import io.github.chrisimx.scanbridge.datastore.shownMessagesStore
import io.github.chrisimx.scanbridge.datastore.updateSettings
import io.github.chrisimx.scanbridge.proto.copy
import kotlinx.coroutines.runBlocking
import io.github.chrisimx.scanbridge.db.ScanBridgeDb
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.koin.mp.KoinPlatform.getKoin
import tools.fastlane.screengrab.Screengrab
import tools.fastlane.screengrab.locale.LocaleTestRule

Expand Down Expand Up @@ -56,22 +52,8 @@ class ScanBridgeScreenshotTest {

@Before
fun cleanupForTest() {
runBlocking {
composeTestRule.activity.shownMessagesStore.updateData {
it.copy {
thankPlayOne = true
}
}
composeTestRule.activity.lastRouteStore.updateData {
it.copy {
clearLastRoute()
}
}
composeTestRule.activity.appSettingsStore.updateSettings {
clearLastUsedScanSettings()
autoCleanup = true
}
}
val scanBridgeDb: ScanBridgeDb = getKoin().get()
scanBridgeDb.clearAllTables()
}

@Test
Expand Down
Loading
Loading