Repository navigation
docs: refresh AGENTS.md conventions and fix stale guidance - #321
Conversation
|
Helm template coverage
Uncovered detailscharts/clickstack/templates/NOTES.txtUncovered lines: none Uncovered branches: 37:default:fallback charts/clickstack/templates/_helpers.tplUncovered lines: 17 Uncovered branches: 130:range:empty, 132:range:empty, 133:ternary:false, 16:if:true, 194:or(1):true, 211:range:empty, 242:default:fallback, 243:or(1):true, 259:if:false, 327:range:empty, 348:range:empty charts/clickstack/templates/additional-manifests.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/cluster.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/keeper.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/cronjob-check-alerts.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yamlUncovered lines: none Uncovered branches: 40:range:empty charts/clickstack/templates/hyperdx/deployment.yamlUncovered lines: none Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty charts/clickstack/templates/hyperdx/hpa.yamlUncovered lines: none Uncovered branches: 16:with:empty charts/clickstack/templates/hyperdx/ingress.yamlUncovered lines: none Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true charts/clickstack/templates/hyperdx/networkpolicy.yamlUncovered lines: none Uncovered branches: 11:with:empty charts/clickstack/templates/hyperdx/pdb.yamlUncovered lines: none Uncovered branches: 10:with:empty charts/clickstack/templates/hyperdx/secret.yamlUncovered lines: none Uncovered branches: 1:or(2):true, 1:or(3):true charts/clickstack/templates/hyperdx/service.yamlUncovered lines: none Uncovered branches: 14:default:fallback, 9:with:empty charts/clickstack/templates/hyperdx/serviceaccount.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/community.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/password-secret.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/otel-collector/custom-config.yamlUncovered lines: none Uncovered branches: none |
Deep ReviewDocumentation-only change to The two prior PR comments are automated bot output (changeset-bot, helmcov); neither is human feedback requiring action. The changeset-bot "no changeset found" warning is consistent with the repo convention that changesets cover user-facing chart changes, not docs. ✅ No critical issues found. No P2 issues. The remaining items are minor accuracy refinements in a doc whose purpose is accuracy. 🔵 P3 nitpicks (2)
Reviewers (5): correctness, project-standards, maintainability, testing, previous-comments. Testing gaps: None — docs-only change introduces no chart behavior requiring helm-unittest coverage. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. |
Updates
AGENTS.mdto match the repo:warren/.[HDX-<ticket>]rule conflicted with the commit convention). Ticket link only when there is one.make docs-check(notmake docs), also triggers onChart.yaml, and skips withouthelm.# --comments are published; removed the conflicting "document all values with inline comments" line.tests/__snapshot__/reference.templates/otel-collector/, theadditionalManifeststop-level key, and the Node.js/npm requirement for the full-stack integration suite.upgrade-notes,lint-workflows,deep-review, andexternal-contributor-alertsworkflows, theversion-script-smokejob, and the correct release trigger.yarn changeset, thetplexample points at_helpers.tpl, shell examples point at scripts that follow the convention, and Key File Locations lists files instead of commands.Docs-only change; no changeset needed.