Repository navigation
refactor(mcp): use the shared pattern predicate for drill-downs #3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/api': patch | ||
| --- | ||
|
|
||
| refactor: the MCP `clickstack_event_patterns` tool builds its drill-down | ||
| `whereSnippet` with the shared pattern predicate from `@hyperdx/common-utils` | ||
| instead of its own copy. The snippet is unchanged. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| import { minePatterns } from '@hyperdx/common-utils/dist/drain'; | ||
|
|
||
| import { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — Tests for the shared common-utils predicate are left in the api MCP test file Move the Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond |
||
| andSql, | ||
| buildPatternPredicate, | ||
| MAX_PREDICATE_TEMPLATE_LENGTH, | ||
| minePatterns, | ||
| templateToRegex, | ||
| } from '@/mcp/tools/query/patternDrilldown'; | ||
| } from '@hyperdx/common-utils/dist/drain'; | ||
|
|
||
| import { andSql } from '@/mcp/tools/query/patternDrilldown'; | ||
|
|
||
| // RE2 spells code points \x{HHHH} and categories \pZ; JS (with the u flag) | ||
| // spells them \u{HHHH} and \p{Z}. ClickHouse behaviour is covered by | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — Tests for the common-utils predicate now sit in the api package, so common-utils' own suite doesn't cover them
Move the
templateToRegexandbuildPatternPredicatecases intopackages/common-utils/src/__tests__/pattern-predicate.test.tsand keep only theandSqltests here. Today that file only tests extra delimiters andparsePatternPredicate. These cases cover escaping, quotes and backslashes, Unicode whitespace, empty templates andMAX_PREDICATE_TEMPLATE_LENGTH. Because they import the built@hyperdx/common-utils/dist/drain, changingpattern-predicate.tsand running the common-utils tests can't catch a regression in any of them. They also only run against whateverdistwas last built.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping these here: they pin the exact
whereSnippetthis tool returns, and the common-utils suite now also covers the length limit and the no-option round trip (04c8a76).