Skip to content

fix(app): open the alert panel from a dashboard tile's alert button - #3680

Open
gedaliakliger wants to merge 1 commit into
ClickHouse:mainfrom
gedaliakliger:agent/1781-tile-alert-opens-panel
Open

gedaliakliger wants to merge 1 commit into
ClickHouse:mainfrom
gedaliakliger:agent/1781-tile-alert-opens-panel

Conversation

@gedaliakliger

Copy link
Copy Markdown

Summary

The bell on a dashboard tile (and the alert item in a narrow tile's menu) called onEditClick, so it opened the same editor as Edit. Since #3222 the alert form lives in a side panel that opens only on request, so after clicking the bell you had to click Add alert or Edit alert again inside the editor. Tile has declared an onAddAlertClick prop since the v2 dashboard, but nothing wired it.

  • The tile's alert actions now call onAlertClick, which opens the tile editor with the new defaultAlertPanelOpened.
  • EditTimeChartForm then opens the alert panel from the start, on the tile's alert. A tile without one gets a new alert, filled in as the Add alert button fills it (DEFAULT_TILE_ALERT plus the tile name as display name), and the panel opens it as a draft, so closing the panel discards it, as with the button.
  • The new alert is only added where the editor offers alerts: a saved dashboard, not local mode, and savedChartConfigSupportsAlerts. On a temporary dashboard the bell still opens a plain editor.
  • Until the chart has run once, a run ignores the new alert: it has no webhook yet, and since the form's resolver checks only the alert, the first run would otherwise stop there and leave the preview empty. That run, whether automatic or by hand (a raw SQL tile with no source doesn't run on open), previews the chart without the alert and shows no alert errors. Later runs check the alert as before.

eugeneo17's #3194 fixed this before the alert panel landed and was closed by the open-PR limit; its review is where the temporary-dashboard case came up.

Checks run here: the five related suites (DBEditTimeChartForm, AlertPanel, AlertPanelButton, TileAlertEditor, EditInlineAlertModal, 95 tests), ESLint and Prettier on the changed files (no new warnings), node scripts/ci/ratchet.mjs, and tsc --noEmit on packages/app. Left to CI: lint and unit tests across packages, and E2E. No unit test covers the DBDashboardPage wiring, since the page has no component test harness; the E2E dashboard specs already reach the button through getTileButton('alerts').

Screenshots or video

I couldn't capture these: local mode hides the tile alert editor (yarn app:dev:local and the Vercel preview), and the full stack needs Docker, which I don't have here.

Before After

How to reproduce

Starting point: yarn dev (alerts need the API), a saved dashboard with a Line or Number tile on the Logs source.

On main:

  1. Hover the tile and click its bell (Add alert).
  2. The tile editor opens without the alert panel. Add alert has to be clicked again inside the editor.

On this branch:

  1. Click the tile's bell: the editor opens with the alert panel showing a new alert. Add alert under its fields confirms it; closing the panel discards it.
  2. On a tile that has an alert, the bell opens the editor on that alert, with Update alert.
  3. On a temporary dashboard (New Dashboard → Temporary Dashboard), add a Line tile and click its bell: the editor opens without an alert, as before.

How to test on Vercel preview

N/A: the tile alert editor is hidden in local mode, so the preview can't show it.

References

The tile's bell opened the plain tile editor, so the alert panel needed a
second click. It now opens the editor on the tile's alert, or on a new draft
where the editor offers alerts.
@gedaliakliger
gedaliakliger requested a review from a team as a code owner November 16, 2026 17:41
@vercel

vercel Bot commented Nov 16, 2026

Copy link
Copy Markdown

@gedaliakliger is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7585904

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking the Add Alert Icon on a Dashboard Tile does not open the modal with the alert editor

1 participant