Repository navigation
fix(mcp): shorten trace_top_time_consuming_operations to trace_top_time_consuming_ops - #3698
Conversation
…ace_top_time_consuming_ops
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2abe867 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines1 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Duplicate code analysis1 new clone introduced by this PR.
If one of these duplicates a helper that already exists, import it instead jscpd compared this branch against |
Deep ReviewScope: mechanical rename of the MCP tool ✅ No critical issues found. Verification performed against the diff:
🔵 P3 nitpicks (1)
Reviewers (4): correctness, testing, project-standards, previous-comments. Testing gaps: none substantive — existing trace-tool integration tests were updated in place and a tool-name-length guard was added; the jscpd "new clone" between No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 467 passed • 1 skipped • 1082s
Tests ran across 4 shards in parallel. |
Summary
Renames the MCP tool
clickstack_trace_top_time_consuming_operations(46 chars) toclickstack_trace_top_time_consuming_ops(39 chars).It was our longest tool name. Some MCP clients cap tool name length (and many prefix the server name on top), so the long name could be truncated or rejected. The shorter name keeps it inside the safe range for most clients.
Updates the registration, error message, cross-references in other tool descriptions, integration tests, and
MCP.md. Historical CHANGELOG entries are left as-is.Breaking for callers using the old name — agents discover tools via
tools/list, so most clients pick up the new name automatically.How to reproduce
Starting point:
yarn dev, connect an MCP client to the API's/mcpendpoint.On
main:clickstack_trace_top_time_consuming_operationsis present.On this branch:
clickstack_trace_top_time_consuming_opsis present and behaves the same.How to test on Vercel preview
N/A — non-UI change.