Repository navigation
Conversation
openFilterGroup clicked the middle of the whole filter group. A group with an active filter auto-expands on load, so that click either collapsed the group or landed on a value row's hover "Only" button and replaced the selected filter. Read the accordion's data-active state, click only the header while closed, and retry until the group reports open.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Deep Review✅ No critical issues found. The fix is correct and a clear net reduction in flakiness. 🔵 P3 nitpicks (3)
Reviewers (5): correctness, testing, maintainability, julik-frontend-races, kieran-typescript. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 468 passed • 1 skipped • 1151s
Tests ran across 4 shards in parallel. |
Summary
Fixes a flaky E2E test,
should save and restore filters with saved searches. The bug is in theopenFilterGrouptest helper, not the app.openFilterGroupclicked the middle of the whole filter group. A group with an active filter opens by itself on load, so when the test reloads the saved search,SeverityTextis often already open. The blind click then did one of two things:element(s) not found.infobecamedebug):Received: unchecked.The helper now reads the accordion's
data-activeattribute and clicks thefilter-group-controlheader only while the group is closed. It retries until the group reports open. That retry also covers a group that opens by itself just after the check, where the click would collapse it again. The existing wait for the open animation to finish is unchanged.Every caller of
openFilterGroupmeans "make sure it's open", so dropping the toggle behaviour doesn't change what any test expects.Both failure modes showed up in downstream CI: the test failed all three attempts in one shard. I haven't seen it fail on this repo's
Mainruns yet, but the same helper, test and auto-expand behaviour are here.How to reproduce
Starting point: local E2E stack (
make dev-e2e).On
main:make dev-e2e FILE=saved-search GREP="filters with saved searches" ARGS="--repeat-each=10"On this branch:
Local results on this branch:
search-filtersandshared-filters: 8/8 passed each.saved-search, whole file twice: 38 passed. The two failures were in tests that don't use the helper (a row-load timeout and a back-navigation timeout).How to test on Vercel preview
N/A. This is a test-only change.
References