Repository navigation
feat(app): hidden CRT mode, unlocked by the secret code in preferences - #3704
Conversation
🦋 Changeset detectedLatest commit: a6d7ba6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
E2E Test Results✅ All tests passed • 476 passed • 1 skipped • 1030s
Tests ran across 4 shards in parallel. |
| label="CRT mode" | ||
| description="Make the screen look like an old CRT monitor" | ||
| > | ||
| <Switch |
There was a problem hiding this comment.
🟡 P2 — The CRT mode switch has no accessible name
SettingContainer renders "CRT mode" as plain text in a sibling div that is not linked to the Switch, so a screen reader announces only "switch, off". Give the switch a name: pass aria-label="CRT mode", or use the Switch's own label prop.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
2 finding(s): 🔴 0 P0/P1 · 🟡 1 P2 · 🔵 1 P3 None could be anchored to changed lines; they are listed below. 1 P3 folded at the bottom. Findings outside the changed lines
🔵 1 P3 — no action needed before merge
Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is an off-by-default cosmetic easter egg: the new 🟡 P2 -- recommended
🔵 P3 nitpicks (4)
Reviewers (8): correctness, testing, maintainability, project-standards, agent-native, kieran-typescript, julik-frontend-races, adversarial. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
| pointer-events: none; | ||
| background: #fff; | ||
| opacity: 0; | ||
| animation: flash 0.6s ease-out; |
There was a problem hiding this comment.
🟡 P2 — The position: fixed flash is probably clipped to the modal instead of covering the viewport
.flash renders inside the Mantine Modal content. Mantine's Transition normally keeps its in styles applied after the modal has opened, and the default modal transition sets a transform (likely translateY(0)). Any non-none transform makes the modal content the containing block for fixed-position children, and that content has overflow-y: auto, so inset: 0 would size the flash to the modal and clip it there. I couldn't confirm this for Mantine v9 because node_modules isn't installed here, so check it in a browser. If it holds, render the flash with Mantine Portal (or createPortal to document.body) so it covers the screen as intended.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
Name the switch for screen readers, keep it visible after CRT mode is turned off, and render the unlock flash outside the modal so it covers the viewport. Adds tests for turning the mode off and for the overlay's class on <html>.
Summary
Adds a hidden CRT mode as an easter egg. Typing the Konami code with the Preferences modal open reveals a "CRT mode" switch, and turning it on makes the whole app look like an old CRT monitor.
prefers-reduced-motion.Screenshots or video
Not attached: I could not upload images from the CLI. The unlock scene is an animation, so a short video is the better fit here.
How to reproduce
Starting point:
yarn app:dev:local, then "Connect to Demo Server".On
main:On this branch:
How to test on Vercel preview
Preview routes: /search
Steps:
user-menu-trigger, thenuser-preferences-menu-item.crt-mode-switch.crt-mode-switch.crt-overlayis present on the page.crt-mode-switchagain and verifycrt-overlayis gone.