Skip to content

fix: make org API keys empty state full width - #3706

Merged
jordan-simonovski merged 1 commit into
mainfrom
cursor/org-api-keys-empty-state-full-width-27ca
Nov 18, 2026
Merged

jordan-simonovski merged 1 commit into
mainfrom
cursor/org-api-keys-empty-state-full-width-27ca

Conversation

@MikeShi42

@MikeShi42 MikeShi42 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

On Team settings, the "No organization API keys yet" empty state was a narrow centered box instead of spanning the section like the keys table does. EmptyState's card variant caps itself at 600px and centers unless fullWidth is set. This passes fullWidth in OrgApiKeysSection.

Screenshots or video

Team settings → API & Agents, fresh team with no org keys, 1440×1000, dark theme. Measured in the browser: the card was 600px wide inside a 1108px section; it is now 1108px.

Before After
Before After

Full page on this branch, where the card now lines up with the API key cards above it:

After, full page

How to reproduce

Starting point: yarn dev (full stack; team settings needs the API) on a team with no organization API keys.

On main:

  1. Open Team settings → "API & Agents".
  2. The "No organization API keys yet" box is narrower than the section and centered.

On this branch:

  1. Same steps. The box spans the full width of the section.

How to test on Vercel preview

N/A — the org API keys section is hidden in local mode, which the preview runs.

References

Open in Web Open in Cursor 

Co-authored-by: Mike Shi <mike@hyperdx.io>
@MikeShi42
MikeShi42 requested a review from a team as a code owner November 18, 2026 07:22
@changeset-bot

changeset-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a899d4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 18, 2026 7:26am UTC
hyperdx-storybook Ready Ready Preview Nov 18, 2026 7:26am UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 6
  • Branch: cursor/org-api-keys-empty-state-full-width-27ca
  • Author: MikeShi42

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 106 in total (1.13%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This PR adds the fullWidth prop to the variant="card" EmptyState in OrgApiKeysSection.tsx so the "No organization API keys yet" empty state spans the section width instead of a centered 600px card. The prop is already defined on EmptyStateCardProps in EmptyState.tsx and is correctly gated to the card variant by the discriminated union (fullWidth?: never on the default variant). The change makes the empty state consistent with the full-width keys Table rendered in the populated branch, introduces no new logic or abstraction, and ships with a matching changeset.

No P0/P1/P2/P3 findings. The single behavioral change is a presentational maw/mx width toggle with no testable logic, no edge cases, and no contract impact.


Reviewers (4): correctness, kieran-typescript, testing, maintainability.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 475 passed • 1 skipped • 1003s

Status Count
✅ Passed 475
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@jordan-simonovski
jordan-simonovski merged commit ca4ceae into main Nov 18, 2026
33 checks passed
@MikeShi42
MikeShi42 deleted the cursor/org-api-keys-empty-state-full-width-27ca branch November 18, 2026 07:35

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — a899d4a0 Deployed Nov 18, 2026 by vercel[bot]
Preview – hyperdx-storybook — a899d4a0 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants