Repository navigation
fix: make org API keys empty state full width - #3706
Conversation
Co-authored-by: Mike Shi <mike@hyperdx.io>
🦋 Changeset detectedLatest commit: a899d4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Deep Review✅ No critical issues found. This PR adds the No P0/P1/P2/P3 findings. The single behavioral change is a presentational Reviewers (4): correctness, kieran-typescript, testing, maintainability. |
E2E Test Results✅ All tests passed • 475 passed • 1 skipped • 1003s
Tests ran across 4 shards in parallel. |
Summary
On Team settings, the "No organization API keys yet" empty state was a narrow centered box instead of spanning the section like the keys table does.
EmptyState'scardvariant caps itself at 600px and centers unlessfullWidthis set. This passesfullWidthinOrgApiKeysSection.Screenshots or video
Team settings → API & Agents, fresh team with no org keys, 1440×1000, dark theme. Measured in the browser: the card was 600px wide inside a 1108px section; it is now 1108px.
Full page on this branch, where the card now lines up with the API key cards above it:
How to reproduce
Starting point:
yarn dev(full stack; team settings needs the API) on a team with no organization API keys.On
main:On this branch:
How to test on Vercel preview
N/A — the org API keys section is hidden in local mode, which the preview runs.
References