Repository navigation
feat(app): find settings and preferences from the Cmd+K menu - #3707
Conversation
Team settings sections open their tab and scroll to the section, Preferences opens the preferences modal, and color mode entries switch the theme. Co-authored-by: Mike Shi <mike@hyperdx.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 87d0e97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
3 finding(s): 🔴 0 P0/P1 · 🟡 2 P2 · 🔵 1 P3 None could be anchored to changed lines; they are listed below. 1 P3 folded at the bottom. Findings outside the changed lines
🔵 1 P3 — no action needed before merge
Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
E2E Test Results✅ All tests passed • 474 passed • 1 skipped • 1037s
Tests ran across 4 shards in parallel. |
Deep ReviewSpotlight (Cmd+K) settings/preferences feature. No P0/P1 issues surfaced: I independently cross-checked all nine deep-link ✅ No critical issues found. 🟡 P2 -- recommended
🔵 P3 nitpicks (3)
Reviewers (4): testing, maintainability, agent-native, learnings-researcher. Agent-native found no parity gaps (spotlight is a human-convenience layer over navigation/theme; the agent surface is the MCP server, unaffected). Learnings-researcher found no applicable prior solutions in Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
Summary
Settings were only reachable by clicking through Team settings tabs or the user menu. The Cmd+K menu now finds them and opens the right place:
/teamrenders nothing there): Team settings, Sources, Connections, Team members, API keys, Organization API keys, MCP server, Export to Terraform (flag-gated), Webhooks, Query settings. Each one opens/team?tab=<tab>#<section-id>, using the tab values and section idsTeamPagealready defines.Supporting changes:
useUserPreferencesModal), so the spotlight can open the modal that AppNav renders.TeamTabContentscrolls the anchored section into view once the team has loaded. Next's own hash scroll runs before the tab content exists on a cold load, so without this the onboarding MCP link (/team?tab=api-agents#team-api-agents-mcp-server) also landed at the top.spotlightSettingsActions.tsxsoSpotlights.tsxstays under 300 lines. The old "Team Settings" menu entry moved into the new group as "Team settings".Not included: the Access tab (security policies). It only appears when the team has
allowedAuthMethods, and adding it would mean fetching the team on every page.Screenshots or video
The "Before" column is empty because
mainreturns "Nothing found" for these queries. I took these screenshots in local mode, so the Settings group doesn't appear in them.How to reproduce
Starting point:
yarn app:dev:localconnected to the demo server for preferences. Useyarn devfor the Settings group, which needs the API.On
main:On this branch:
yarn dev) Press Cmd+K, type "mcp", and select "MCP server". Team settings opens on the "API & Agents" tab, scrolled to "Connect your AI Agents". Try "users" (Team members) and "api key" (API keys) too.How to test on Vercel preview
Preview routes: /search
Steps:
References