Repository navigation
feat: SQL query filter follow-ups: table autocomplete, type rename, type-switch fix, E2E tests - #3719
Draft
karl-power wants to merge 4 commits into
Draft
karl-power wants to merge 4 commits into
karl-power wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: faebc7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
karl-power
force-pushed
the
claude/sql-filter-autocomplete
branch
from
November 18, 2026 17:57
038f28f to
faebc7c
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from review on #3678: autocomplete table and column names in the SQL query filter editor, rename "Queried values", fix a validation bug when switching filter types, and add E2E coverage for SQL query filters. One commit per change:
getTableConnectionsForConnection()inutils.ts, which both editors use.$__sourceTableand$__filter, a connection variable, a data source variable, and a query error shown in the preview and on the dropdown.Screenshots or video
Not captured. The visible changes are autocomplete suggestions in the SQL query filter editor and the renamed, reordered type dropdown.
How to reproduce
Starting point:
yarn dev, any dashboard, with a Logs source on the local connection.On the base branch (#3691):
On this branch:
otel. The tables of the connection's sources are suggested, and afterFROM, their columns.How to test on Vercel preview
Preview routes: /dashboards
Steps:
SELECT * FROM otelin the SQL editor. Verify table names appear in the suggestions.References