ci: declare contents:read on unit-tests workflow#1027
Closed
arpitjain099 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Author
|
Merging mentally with #1040 which covers this plus more files. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow-level
permissions: contents: readblock. The job here only checks out the repository and runs its tests / validation; no GitHub API call beyond the initial checkout is needed.CVE-2025-30066 (the March 2025
tj-actions/changed-filessupply-chain compromise) is the canonical motivation: a tampered third-party action exfiltratedGITHUB_TOKENfrom workflow logs and the leaked token retained whatever scope was issued at the workflow level. Per-workflow caps bound that runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and register with OpenSSF Scorecard's Token-Permissions check (which only credits explicit per-workflow declarations).YAML validated locally with
yaml.safe_load.Note
Low Risk
Workflow-only permission tightening with no application or runtime behavior changes.
Overview
Adds an explicit workflow-level
permissions: contents: readto the Unit tests GitHub Actions workflow so the job token is limited to checkout/read—matching the pattern already used on other workflows and satisfying OpenSSF Scorecard token-permissions expectations.No test or install steps change; this only caps
GITHUB_TOKENscope at runtime (e.g. to reduce blast radius if a third-party action is compromised).Reviewed by Cursor Bugbot for commit f9edad4. Bugbot is set up for automated code reviews on this repo. Configure here.