Repository navigation
Conversation
…are takes the same lock The attach command holds the attach lock on a direct, marked session of the cell's Postgres for its run and resumes by the directory row and the cell's mode. It refuses before any write on the stores' identity, the session, the roles, settings and subscriptions that would let an unchecked writer through, the database encoding, durability, its own grants, the ClickHouse writers, the table list and the processes' heartbeats; posts attach/begin; creates the triggers under the migration lock; in recording scans and writes the tenancy rows, refusing an org past ORG_MAX_BYTES; commits enforced, proves it durable, waits out every transaction that could have read recording, rescans, places every org in batches and marks the cell serving. A refusal after the mode commit leaves the cell enforced and attaching, and a rerun resumes there. Prepare refuses a session behind a pooler or a database that is not UTF8, and takes the attach lock. Doctor runs attach's Postgres reads again and reads stray orgs with --stray-orgs. instances.read_recent keeps stopped rows inside the widened window, and PRUNE_AFTER_S names the sweep's hour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…t gate measured end to end docs/operations/cell-attach.md is the operator's procedure: the preconditions attach checks and those it relies on, the flags, the point of no return at the mode commit, the orgs attach does not place and the manual removal of an org past the length limit, and doctor's reads after serving. cells.md describes the first attach as it runs (the lock, the refusals, the trigger pass, the mode commit and its durable read, step 4's wait, rescan and final checks), with its stated limits and failure rows. upgrades.md step 18 rotates the ClickHouse writer credential after the LOOM_CELL rollout. bench/cell_trigger_gate.py measures memory.set and a delivery-sized insert through an attached cell with the org triggers on and off; results.md records a local run. Attach compares the final root-secret fingerprint with the one its begin wrote, and the nonce cleanup's message names no single command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…s no boot or insights module instances.read_recent takes the window it reads back; attach's heartbeat module computes it from the live window and a stopping process's drain and retirement budgets. PRUNE_AFTER_S is marked as the contract it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
… in wall time, and says when the mode commit's outcome is unknown The refusals name every table the trigger pass would alter whose owner role attach's role is not a member of, before any write; ensure_table and _run_ddl answer applied, busy or denied, so a denial during the pass refuses at once rather than after --wait as a busy lock. --wait is wall time: each bounded wait charges its elapsed time, lock tries included, and every lock try waits at most what is left; scan time stays outside it. From the mode commit on, a stop that comes before the durable read says the commit's outcome is unknown and to rerun attach, for a refusal and for any other error alike. The prune-window check runs with the refusals, before any write; an enforced resume runs one trigger pass; the lock session opens inside the block that closes it; the durable read retries a timeout or an outage only; refusals name no command that does not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
… the attach docs describe one step numbering and today's procedure --stray-orgs labels only a spent budget as tables left unchecked; any other refusal names its table and the read continues. A failed catalog read reports both of attach's Postgres checks as not read. The runbook and doctor describe removing a stray or over-long org by hand, and name no command that does not exist yet. cells.md labels the first attach's list with the design's step names, so step 1 to step 4 mean the same everywhere, rewrites the stuck-process failure row and the planned tests for a mode that only rises, and says --wait is wall time. The trigger-cost harness uses cell_triggers.create_statement and deletes the rows its inserts wrote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
… inside --wait, and doctor warns on the role it runs as The mode is taken from the first state read, set to unknown only once the router accepted attach/enforced, and set from what the durable read saw; an interrupt prints the mode line and goes on. The trigger DDL's lock bound is taken after the migration lock, from what --wait has left then. An ended mode transaction whose lock does not clear refuses, naming its backend. A busy table's holders come back with ensure_table's answer, and attach says them once per change rather than a boot's warning a try. Attach counts the role it runs as among its own; doctor does not. The dead SCIM recheck and the unused scim_ok parameter are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
… figures say what they establish cells.md and the runbook state that attach exempts the role it runs as and doctor does not. results.md gives the marked batch's per-round changes and their mean, says the delivery-pass gate is met on the mean but not established by three rounds alone, and that the memory.set p99 gate is unresolved locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…nknown only while a try's UPDATE is out, and a busy migration lock is named Each trigger and mode-commit try gets a lock wait of at least TRY_FLOOR_MS before --wait is judged spent, so --wait 0 is one try of each wait with no retry, and an idle cell attaches with it. The run's mode turns unknown just before a try sends its UPDATE and back to recording when that try rolls back. A trigger try that finds the migration lock busy names that lock's holder, in the retry line and in the refusal. The step-4 watch task is awaited after its cancel. The ATTACH_LOCK_KEY comment says who holds the lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…span on one line inside its list items Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Check each probe privilege separately because a comma-separated privilege list accepts any one of them. Run the attach integration tests in the Postgres matrix and limit their heartbeat reads to the test's own process IDs while retaining the real queries. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Manage mode and direct-session transactions explicitly so a canceled statement cannot start an unbounded rollback. Roll back ordinary mode statement errors within the try's deadline; terminate synchronously when a try ends with an error or cancellation. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Give each trigger attempt a client deadline covering migration lock acquisition, DDL, commit, rollback and unlock. Use explicit transactions so cancellation terminates the session without waiting for rollback or masking the original error with lock cleanup. Give gate batch scopes a unique prefix per run so cleanup preserves existing rows. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Count privileges a login can reach through SET ROLE or an ADMIN regrant, including noninherited group grants. Keep the owner exemptions and explicit role allow list. Repeat the writer, trigger, Postgres catalog and standby checks after the rescan and placement before marking the cell serving. Retain the heartbeat watch and its final wait floor. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Check USAGE of pg_read_all_stats and pg_signal_backend because attach uses their privileges without SET ROLE. Keep MEMBER for the separate untrusted-writer reachability checks. Refuse noninherited capabilities before attach writes, and explain the inherited grant requirement in the refusal labels and runbook. Test both inherited neighbors and signaling a scratch backend. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Concurrent index builds release the ordinary migration key so a shipped blocking migrator can finish without retaining a snapshot behind the build. Retry from the catalogs and checksum ledger, and acknowledge a WAL fence on recorded reruns. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Claim a fresh directory UUID before acceptance writes, and compare the generation, registration and exact fingerprint pair on control mutations. Keep every local acceptance transaction on its attach-lock backend and stop after a lost session. The additive router column permits older data-plane reads and inserts. Online control requires turnover of older clients and router handlers; the recovery guide covers claimed state cleanup and offline generation rotation. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Refuse explicit open requests under the guarded attaching row lock, preserving quota atomicity and the durable zero-placement boundary. Inventory control writers and their required boundaries, including dynamic cleanup SQL. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Concurrent index builds release the ordinary migration key so a shipped blocking migrator can finish without retaining a snapshot behind the build. Retry from the catalogs and checksum ledger, and acknowledge a WAL fence on recorded reruns. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Send public driver cancellation before aborting the transport, within one absolute cleanup deadline. Separate borrowed migration execution so its operator keeps sole session supervision. Verify backend lock release and preserve interrupted migration errors. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Send public driver cancellation before aborting the transport, within one absolute cleanup deadline. Separate borrowed migration execution so its operator keeps sole session supervision. Verify backend lock release and preserve interrupted migration errors. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Supervise bounded Postgres phases independently, reserving cleanup inside each existing deadline. Send public close while query and transaction work are alive, then cancel and reap within that same bound. Borrowed checks and trigger DDL leave failed-session cleanup to their owner. Bound the lock owner's close and preserve its original failure across cleanup errors or repeated cancellation. Keep wait floors and normal busy retries. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Supervise bounded Postgres phases independently, reserving cleanup inside each existing deadline. Send public close while query and transaction work are alive, then cancel and reap within that same bound. Borrowed checks and trigger DDL leave failed-session cleanup to their owner. Bound the lock owner's close and preserve its original failure across cleanup errors or repeated cancellation. Keep wait floors and normal busy retries. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Supervise attach, prepare, removal and backout on their exact lock backend. Keep cleanup inside phase deadlines, forward fatal guard exceptions after close, and retry mode contention only after acknowledged rollback and ownership checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
A same-name string projection masks the UUID filter in the native query. Read the native UUID and normalize its returned identity while retaining every retirement predicate. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Restart an incomplete census only after a nonroot process is proven absent. Bound retries by the original freshness interval and retain identity, ownership and resource refusals. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every workload field and acceptance oracle unchanged while updating the fixed descriptor checksum. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The option can be visible before its keyboard selection effect runs. Require that selection before the existing Enter action and retain every geometry assertion. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep numeric error codes and bounded cause classes without exception text or connection details. Validate the sidecar before attaching it to the original failure; execution and cleanup guards remain unchanged. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Collect read-only participant and configuration-lease counts before the failed fixture stack is removed. Keep the original activation failure and deadline when diagnostics fail or time out. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Preserve the wrapped cause, error identifiers and commit uncertainty when staging refuses, without changing workload, retry or acceptance rules. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
A child can exit before completing its own retirement. The parent records retirement only after its captured child identity is physically gone and every tagged query has ended, within the existing stop or restart deadline. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Wire exact-proof retirement from the serving composition root and expose its bounded proof timeout through settings. Keep the original child identity, query-settlement and cleanup deadlines. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Capture exact background-child births before controlled crash and recreation. Keep certified retirement and settled queries mandatory for every captured participant, and report bounded role counts on failure. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Cover finite positive retirement budgets and the original remaining allowance. Distinguish an already issued scoped token from native minting after enforcement. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Model the captured process stat records and assert all closed kernel counts. Keep identity and secrecy controls and cover missing, unreadable and reused process observations. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the existing store checks and failure envelope while giving each refused observation its own source site. Protect the native test child with the same kill and wait ownership as neighboring tests. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The initialization server can answer native queries before its final HTTP listener starts. Probe the published endpoint through the existing bounded creator command. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
A zombie leader can still report multiple threads. Keep polling within the existing allowance until the complete asserted exit state is observed. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The fixture owns the child through timeout and cancellation. Keep its existing wait budget and always collect that exact process before store cleanup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Cancel and join the owned task before dedicated sessions close on an interrupted control operation. Preserve the contention checks and wait allowances. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Give each in-process test its own real gate while keeping shutdown permanent within the scenario. A private patch context preserves the fixture through explicit test monkeypatch cleanup. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
A canceled head-lock query leaves its cancellation mechanism and query plan unknown. Record closed reasons and a bounded fresh planning observation while retaining the original failure and cleanup contract. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #693
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
loom cell attachplaces a prepared first cell’s orgs, installs its tenancy triggers and makes it serve routed traffic. Attach verifies store pairing and fences stale control requests; native token minting requires reachable, migrated stores, and manual participant retirement verifies physical death instead of accepting--yes.Why
A prepared first cell cannot serve routed traffic until its placements, tenancy mode and triggers agree. Attach advances those states in order, verifies the durable result and resumes an interrupted attempt from recorded state. A cell already marked serving must pass the same deployment, configuration, cell and bucket-pairing checks before the command reports success.
Scope and risk
enforced. Failure after that mode commit leaves the cell enforced; recovery proceeds forward.LOOM_NATIVE_COMMAND_DRAIN_TIMEOUT_Sgives a native command its complete cleanup allowance, defaulting to 15 seconds.LOOM_WORKERS_CHILD_RETIREMENT_TIMEOUT_Scaps a reaped child’s proof work, defaulting to one second within the original remaining stop or restart allowance. Both must be positive and finite; expiry leaves retirement unproved.The main risks are incomplete control-fleet turnover, a writer role that can bypass tenancy checks, and store configuration changing during attach. The command refuses detectable violations; the runbooks name the process and configuration evidence an operator must establish. Later-cell administration and a complete capacity model are separate concerns.
Compatibility, rollout and rollback
loom mint-tokenrequires reachable, migrated stores; offline minting refuses.loom participant retire --yesis removed. Manual retirement runs on the trusted host that can verify exact physical death and settled queries.CONTROL_UPGRADE_REQUIRED. No data-plane operation is removed.docs/operations/cell-control.md, and followdocs/operations/cell-attach.md. Prepare and attach require direct Postgres connections and a synchronous standby. Rotate the ClickHouse writer credential after the cell rollout and before attach.Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Claude Code and Codex. Independent reviews check the complete control protocol, failure paths, store pairing, operator procedures and regression evidence.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist