Skip to content

Codex hooks have descriptive Loom labels - #761

Open
zlareb1 wants to merge 5 commits into
mainfrom
fix/codex-hook-labels
Open

zlareb1 wants to merge 5 commits into
mainfrom
fix/codex-hook-labels

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry:

The Codex /hooks browser shows each Loom hook's purpose instead of "Unnamed hook".

Why

The hooks browser uses statusMessage as the display title. Each of the 22 hook definitions supplies a concise Loom-prefixed label so users can identify its purpose.

Scope and risk

The change adds display metadata to the Codex hooks file and bumps both plugin manifests to 1.2.31. Commands, Windows commands, event matchers, ordering and hook execution stay the same. The existing parser-field contract accepts the supported statusMessage field; it continues to reject unknown fields. Fail-open test retries use fresh sessions so a cached empty lookup cannot suppress the next HTTP check. Their request assertions, deadlines and retry limit stay the same.

Compatibility, rollout and rollback

  • Wire: none. statusMessage is supported hook metadata.
  • Operator steps: update the plugin through the normal distribution flow. The changed package may require renewed trust through the normal prompt.
  • Rollback: revert the labels and publish a new plugin version. No stored data or migrations change.

Tests

Local checks:

  • Prettier 3.9.9 checked all five changed files; git diff --check passed.
  • node --check passed for both changed test files.
  • All 22 labels match the reviewed label set. Removing statusMessage reproduces the base hook wiring byte for byte. Each manifest changes only its paired version, and the merged plugin guidance is preserved.
  • Local runtime checks could not start because the test supervisor refused admission. No runtime test result is claimed for this revision.

Full unit, coverage, offline benchmark, integration, browser and plugin platform suites must pass in PR CI. The upstream parser test accepts statusMessage. No new test duplicates the static label mapping.

AI assistance in the code

AI-generated with Codex. Reviewed all labels and verified that removing statusMessage leaves the hook wiring identical and that the manifests change only their paired version.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • make format-check, make lint, make typecheck and make test-unit pass; the integration suite passes if server behaviour changed.
  • Generated files match their source; plugin copies are checked by agent_plugin_sync --check.
  • No migration changes.
  • Both plugin manifests use a version reserved for this change.
  • No frontend changes.
  • No server wire or operator configuration changes.
  • Repository text contains no deployment details.
  • Commits are signed off.

@zlareb1
zlareb1 requested a review from dkong16 November 17, 2026 21:50
@zlareb1
zlareb1 force-pushed the fix/codex-hook-labels branch from b84732a to d9db850 Compare November 18, 2026 07:53
Show each hook’s purpose in the hooks browser through statusMessage metadata.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The hook validates memory keys written during the session.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the handler-field allowlist aligned with the supported statusMessage field.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Give each retry a new session so cached empty lookups do not suppress its request.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Publish the hook labels with a plugin version distinct from other pending changes.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/codex-hook-labels branch from 98115b1 to 32b85b8 Compare November 18, 2026 09:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant