Skip to content

Git preserves plugin launcher and skill bytes on checkout - #767

Merged
zlareb1 merged 1 commit into
mainfrom
fix/plugin-byte-preserving-checkout
Nov 17, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/plugin-byte-preserving-checkout

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 17, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry

Shell launchers and skill files preserve their committed LF bytes when Git checks them out, including with automatic CRLF conversion enabled.

Why

Plugin directory validation rejects Git attributes that rewrite file contents. The root attributes currently normalize shell launchers and skill frontmatter to LF. Disabling conversion for the same paths preserves their existing LF bytes and lets a checkout keep runnable shell scripts without rewriting them.

Scope and risk

The same six attribute patterns and a checkout-byte regression. All protected committed files currently have LF line endings. Since disabling conversion also preserves an accidentally committed CRLF file, the regression checks committed bytes as well as actual Git checkouts under three autocrlf settings. An unprotected text control verifies that the CRLF checkout case really converts ordinary text.

The installed plugin files are byte-identical, so no plugin version bump is needed for this packaging constraint. Actual signed-in directory acceptance remains unmeasured; this resolves the published attribute requirement locally.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: revert the attributes and checkout tests.

Tests

  • make format, make format-check, make lint and make typecheck pass on the current source.
  • The added regression covers committed LF bytes, three actual Git autocrlf checkout settings and an unprotected text control. It has not run locally.
  • Full unit, benchmark and platform checks must pass in PR CI before merge.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff): Codex checked Git conversion semantics and wrote the attributes and regression tests.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • make format-check, make lint, make typecheck and make test-unit pass; the integration suite passes if server behaviour changed.
  • No wire, schema, server or plugin source behavior changes.
  • Tests cover committed bytes and real checkout behavior.
  • Public text contains no internal deployment details.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit e4dde83 into main Nov 17, 2026
49 checks passed
@zlareb1 zlareb1 mentioned this pull request Nov 18, 2026
7 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant