Repository navigation
Git preserves plugin launcher and skill bytes on checkout - #767
Merged
Merged
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry
Shell launchers and skill files preserve their committed LF bytes when Git checks them out, including with automatic CRLF conversion enabled.
Why
Plugin directory validation rejects Git attributes that rewrite file contents. The root attributes currently normalize shell launchers and skill frontmatter to LF. Disabling conversion for the same paths preserves their existing LF bytes and lets a checkout keep runnable shell scripts without rewriting them.
Scope and risk
The same six attribute patterns and a checkout-byte regression. All protected committed files currently have LF line endings. Since disabling conversion also preserves an accidentally committed CRLF file, the regression checks committed bytes as well as actual Git checkouts under three autocrlf settings. An unprotected text control verifies that the CRLF checkout case really converts ordinary text.
The installed plugin files are byte-identical, so no plugin version bump is needed for this packaging constraint. Actual signed-in directory acceptance remains unmeasured; this resolves the published attribute requirement locally.
Compatibility, rollout and rollback
Tests
make format,make format-check,make lintandmake typecheckpass on the current source.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex checked Git conversion semantics and wrote the attributes and regression tests.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed.