Skip to content

Explain repository tags when agents save code-related facts - #787

Merged
zlareb1 merged 2 commits into
mainfrom
fix/plugin-memory-code-guidance
Nov 18, 2026
Merged

zlareb1 merged 2 commits into
mainfrom
fix/plugin-memory-code-guidance

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Improvement

Changelog entry

The coding-agent primer and memory tool descriptions explain how to tag repository-specific facts without tagging unrelated facts.

Why

Hook captures carry a repository tag, but a manually saved repository fact needs the caller to supply that tag. The primer and memory tool descriptions give the same instruction so repository-filtered recall can find those facts. Personal facts stay in the caller's own namespace.

Scope and risk

Changes the session primer, the default and atomic memory tool descriptions, and their checks. Both plugin manifests use version 1.2.29. The generated plugin copy matches its source. The two reviewed-source hashes for the mirrored primer libraries are renewed after auditing their sender paths and request builders. All 85 exception entries and the other 41 reviewed-source hashes remain unchanged; the guard and collector are unchanged.

This change targets main independently of the endpoint configuration change. It changes no plugin skills, endpoint resolution, write handler or authorization rule. Tags remain caller-supplied. The integration regression checks that a manually tagged memory links to code while an untagged memory does not, and checks the stored identity tuple and provenance.

Compatibility, rollout and rollback

  • Wire: no operations, arguments or defaults change.
  • Operator steps: none.
  • Rollback: revert the guidance with another plugin version bump. Existing memories are unchanged.

Tests

  • Changed Python files pass Ruff lint and format checks.
  • Both changed plugin helpers and the changed Node test file pass syntax checks.
  • The plugin mirror check and patch whitespace check pass.
  • Focused local tests did not run: the reviewed launcher refused admission. No local unit-test pass is claimed for this head. Earlier test results belong to earlier heads.
  • The previous head failed the sender-provenance guard and the unchanged macOS accounting check (55.4 ms for 1,000 decisions against a 50 ms limit). This head renews the two audited hashes and makes no performance change.
  • The server integration regression has not run locally. Full PR CI, including the regression and plugin checks, passes on this head.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff): Codex checked the guidance against the tagging and code-link contracts, replayed the guidance commit independently, and ran the static checks above.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • All required PR CI passes on the current head.
  • Generated plugin copies match their source.
  • Both plugin versions match and are distinct from other open PRs.
  • No schema, wire or stored-data change.
  • Commits are signed off.

Manual memory writes need the repository tag to resolve code links from a personal namespace. Scope the guidance to facts about the current repository so other facts keep their own scope.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/plugin-memory-code-guidance branch from 0663fb7 to aa38902 Compare November 18, 2026 06:21
@zlareb1
zlareb1 changed the base branch from fix/plugin-directory-endpoint to main November 18, 2026 06:22
@zlareb1 zlareb1 closed this Nov 18, 2026
@zlareb1 zlareb1 reopened this Nov 18, 2026
The repository-tag wording changes these reviewed body-builder files without changing request construction. Renew only their source pins after auditing the sender paths; keep exception entries and the guard unchanged.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit ce3ad17 into main Nov 18, 2026
54 checks passed
@zlareb1 zlareb1 mentioned this pull request Nov 18, 2026
7 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant