Skip to content

Publish more reviewed documentation translations - #833

Merged
zlareb1 merged 4 commits into
mainfrom
docs/publish-reviewed-translations-followup
Nov 18, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
docs/publish-reviewed-translations-followup

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Changelog entry

Publish twelve reviewed documentation translations, correct one Korean translation and retain fourteen additional generated pages as pending data.

Why

Verified translations can publish once their translated link destinations exist. Four pages move unchanged from pending storage, and eight additional pages join them. A model-generated Korean replacement preserves the meaning of qualified names. Other translations wait for their dependencies or updated English sources.

The lifecycle checker parses the same English fallback source for each link. Each link-validation or repair pass reuses a derived body only when the source path and freshly read text match. This removes repeated parsing while retaining file checks, current reads and parser failures for every link.

Scope and risk

Generated Markdown across the five configured translation languages, plus the existing fallback helper and focused regression tests. The import validates source stamps, model, banners, protected content and dependency closure. Every changed body has an independent complete semantic and native-language review. Two CLI translations retain their original source stamps in pending storage because the English reference changed. Pending pages have no website routes.

Derived-body reuse is limited to one invocation. Changed text reparses; deleted or symlinked sources still fail the existing checks. No cache crosses invocations, and links without fragments still parse their source.

Compatibility, rollout and rollback

  • Wire and settings: none.
  • Operator steps: none. The documentation deployment publishes the available pages after merge. Automatic paid translation runner configuration remains separate.
  • Rollback: reverting restores the replaced translation and four pending paths, removes added generated data and returns fallback validation to per-link parsing.

Tests

  • Maintained provider-free imports and the exact-baseline Korean replacement completed with protected-content and dependency validation. Three invalid input pages were rejected and remain excluded.
  • Focused validation of the initial twenty changed bodies: eighteen pass current source and protected-content checks; two stale CLI bodies pass generated ownership checks and remain pending. The subsequent six-page import and Korean replacement pass the maintained current-source checks.
  • Twelve focused lifecycle cases: two fail before the parsing change and all twelve pass after it. They cover reuse across different anchors, invocation boundaries, changed text, deletion, symlinks and parser errors with and without fragments.
  • Exact generated bytes, source blobs, independent review receipts and active semantic exclusions checked for every changed body.
  • Ruff, Ruff format and git diff --check: pass.
  • Full unit, integration and strict documentation checks run in PR CI and must pass before merge. No heavy local suite ran. A previous CI unit shard exceeded its job limit; no whole-check speedup or timeout resolution is claimed before current-head CI completes.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff): Codex prepared the lifecycle change and generated-data imports, and checked their validation results and independent reviews. Translation prose comes from the approved translation model.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required full checks pass in CI before merge.
  • Generated translations retain their exact model output; no translated prose is edited by hand.
  • No migration, SDK, plugin, frontend or runtime interface changes.
  • English remains canonical and pending coverage remains explicit.
  • Public text contains no private evidence or deployment details.
  • Commits are signed off.

Activate translations whose link dependencies are available and retain the remaining generated pages as pending data. Preserve CLI translations as pending because their English source changed.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep per-link source checks and raw reads while reusing the derived body only
when the source text matches. Source edits reparse; each new pass starts empty.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit 399e53c into main Nov 18, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant