Skip to content

Recall Lab reuses settled scores while editing a query - #837

Open
zlareb1 wants to merge 1 commit into
mainfrom
fix/recall-score-render
Open

zlareb1 wants to merge 1 commit into
mainfrom
fix/recall-score-render

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Related: #786

Changelog category (leave one):

  • Performance Improvement

Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):

Recall Lab reuses settled score rows while the query is being edited. Clearing the query still removes the scores immediately.

Why

Each keystroke rebuilds the eight-cell score table even though its results still answer the previous query. The request debounce postpones the next search, but leaves this rendering work on the input path. The existing browser check reports typing interactions of 216 ms and 224 ms against its 200 ms budget with 100 scores and fourfold CPU throttling.

Scope and risk

Reuse the table element and its derived rows until results, their query, the row-opening callback, loading or result visibility changes. Keep raw query updates, cancellation, the request debounce, namespace clearing, row order, assistant context and accessibility on their existing paths. No request, CSS, timeout, retry or performance-budget change.

The saved browser trace places search responses after typing; it records interaction durations rather than rendering stacks. This patch removes the verified repeated table work. The unchanged browser check must establish whether the interaction meets its budget.

Compatibility, rollout and rollback

No API, schema, dependency or configuration change. No operator step is needed. Rollback restores table construction on each query edit.

Tests

The new regression checks that editing a draft updates the input and keeps the previous result visible without reading its settled score data again or issuing another request; clearing removes the table. Existing namespace-switch, score-bar, row-opening, retry and assistant-context tests remain unchanged.

Final-head GitHub CI passes both frontend test shards, including all eight table tests and the new draft-edit regression. All three browser shards pass. The unchanged 200 ms interaction check with 100 scores and fourfold CPU throttling passes, including typing and clearing; it does not report a numeric after-change duration. A fresh independent whole-change review found no issues or nits. The full run did not pass: a unit shard was cancelled at its unchanged 30-minute limit, leaving coverage skipped. The combined change in the feed PR includes this exact UI patch and the merged translation-check optimization. Its full CI must pass before that combined change can merge.

No local test, browser run or build is claimed; available memory was below the existing admission floor.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff).

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • make format-check, make lint, make typecheck and make test-unit pass; the integration suite passes if server behaviour changed.
  • Generated files are regenerated in this PR, not by hand: the SDK op tables, docs/reference/configuration.md and the docs/reference/ tables (python scripts/codegen/docs_reference.py), the reach manifest, schemas/schema.sql (make schema-dump) and the Codex plugin copies (python3 scripts/codegen/agent_plugin_sync.py).
  • A new migration is additive and numbered after the latest on main; no merged migration is edited.
  • A behaviour change to any file a plugin ships (hooks/, lib/, bin/, skills/, .mcp.json, the Codex plugin-defaults.json) bumps both plugin manifests' version, and no other open PR uses that version.
  • The frontend builds (npm --prefix frontend run build) and its tests pass, if frontend/ changed.
  • Docs under docs/ describe the system as it now is, and this description names any operator steps and wire changes.
  • Repository text has no dates, people, host names, internal namespaces, ticket or decision numbers; the history goes in this description (tests/unit/test_public_copy.py).
  • Commits are signed off (git commit -s), as CONTRIBUTING.md asks.

Draft query edits rebuilt the score table before the debounced search ran.
Reuse the table until its result, loading or opening context changes, while
keeping query cancellation and immediate clearing unchanged.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant