Repository navigation
Conversation
Draft query edits rebuilt the score table before the debounced search ran. Reuse the table until its result, loading or opening context changes, while keeping query cancellation and immediate clearing unchanged. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #786
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Recall Lab reuses settled score rows while the query is being edited. Clearing the query still removes the scores immediately.
Why
Each keystroke rebuilds the eight-cell score table even though its results still answer the previous query. The request debounce postpones the next search, but leaves this rendering work on the input path. The existing browser check reports typing interactions of 216 ms and 224 ms against its 200 ms budget with 100 scores and fourfold CPU throttling.
Scope and risk
Reuse the table element and its derived rows until results, their query, the row-opening callback, loading or result visibility changes. Keep raw query updates, cancellation, the request debounce, namespace clearing, row order, assistant context and accessibility on their existing paths. No request, CSS, timeout, retry or performance-budget change.
The saved browser trace places search responses after typing; it records interaction durations rather than rendering stacks. This patch removes the verified repeated table work. The unchanged browser check must establish whether the interaction meets its budget.
Compatibility, rollout and rollback
No API, schema, dependency or configuration change. No operator step is needed. Rollback restores table construction on each query edit.
Tests
The new regression checks that editing a draft updates the input and keeps the previous result visible without reading its settled score data again or issuing another request; clearing removes the table. Existing namespace-switch, score-bar, row-opening, retry and assistant-context tests remain unchanged.
Final-head GitHub CI passes both frontend test shards, including all eight table tests and the new draft-edit regression. All three browser shards pass. The unchanged 200 ms interaction check with 100 scores and fourfold CPU throttling passes, including typing and clearing; it does not report a numeric after-change duration. A fresh independent whole-change review found no issues or nits. The full run did not pass: a unit shard was cancelled at its unchanged 30-minute limit, leaving coverage skipped. The combined change in the feed PR includes this exact UI patch and the merged translation-check optimization. Its full CI must pass before that combined change can merge.
No local test, browser run or build is claimed; available memory was below the existing admission floor.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff).
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
make format-check,make lint,make typecheckandmake test-unitpass; the integration suite passes if server behaviour changed.docs/reference/configuration.mdand thedocs/reference/tables (python scripts/codegen/docs_reference.py), the reach manifest,schemas/schema.sql(make schema-dump) and the Codex plugin copies (python3 scripts/codegen/agent_plugin_sync.py).main; no merged migration is edited.hooks/,lib/,bin/,skills/,.mcp.json, the Codexplugin-defaults.json) bumps both plugin manifests' version, and no other open PR uses that version.npm --prefix frontend run build) and its tests pass, iffrontend/changed.docs/describe the system as it now is, and this description names any operator steps and wire changes.tests/unit/test_public_copy.py).git commit -s), as CONTRIBUTING.md asks.