Skip to content

Correct faulty translations of unchanged whole pages - #839

Open
zlareb1 wants to merge 1 commit into
mainfrom
fix/i18n-same-input-unit-correction
Open

zlareb1 wants to merge 1 commit into
mainfrom
fix/i18n-same-input-unit-correction

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry

Original-unit reconciliation permits correction of a faulty completed whole-page translation when the prepared English input is unchanged.

Why

The single-unit guard rejects a valid same-input correction before the existing correction planner can retain its completed reference and confirmed faults. Restricting the whole-page replacement refusal to changed input lets unchanged requests use the established correction path.

Scope and risk

One planner condition changes. The correction retains the authentic original unit, manifest digest, fault identifiers and current source context. The existing byte bound applies to the complete request. Changed whole-page inputs, invalid provenance, unknown faults and pair refusals retain their existing conflicts. English documentation already describes same-input correction and remains unchanged.

Compatibility, rollout and rollback

  • Wire and settings: none. The existing pure planning API accepts the same arguments.
  • Operator steps: none. This change makes no provider call or automatic paid-runner configuration change.
  • Rollback: reverting restores the refusal for faulty completed whole-page inputs.

Tests

  • Fifteen small focused checks pass, including an authenticated frozen same-input case that fails before the fix.
  • Regression controls cover fault coalescing, unchanged-input provenance and context, exact byte bounds, changed whole-page inputs, inserted prose, invalid or missing completion references and pair refusal.
  • Ruff, format, prose and git diff --check pass.
  • Full unit, integration and coverage checks run in PR CI and must pass before merge. No heavy local suite ran.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff): Codex diagnosed the planner refusal, changed its condition and wrote the focused regressions.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required full checks pass in CI before merge.
  • Completed-unit provenance, changed-input refusal and request byte bounds remain enforced.
  • No generated translation, provider, prompt, model or budget changes.
  • No migration, SDK, plugin, frontend or runtime interface changes.
  • Public text contains no private evidence or deployment details.
  • Commits are signed off.

A completed whole-page request can retain its original input and reference
when correcting a confirmed fault. Keep changed-page replacement refusal
and the existing request byte bound.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant