Repository navigation
Conversation
A completed whole-page request can retain its original input and reference when correcting a confirmed fault. Keep changed-page replacement refusal and the existing request byte bound. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry
Original-unit reconciliation permits correction of a faulty completed whole-page translation when the prepared English input is unchanged.
Why
The single-unit guard rejects a valid same-input correction before the existing correction planner can retain its completed reference and confirmed faults. Restricting the whole-page replacement refusal to changed input lets unchanged requests use the established correction path.
Scope and risk
One planner condition changes. The correction retains the authentic original unit, manifest digest, fault identifiers and current source context. The existing byte bound applies to the complete request. Changed whole-page inputs, invalid provenance, unknown faults and pair refusals retain their existing conflicts. English documentation already describes same-input correction and remains unchanged.
Compatibility, rollout and rollback
Tests
git diff --checkpass.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex diagnosed the planner refusal, changed its condition and wrote the focused regressions.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist