Repository navigation
feat(metrics): account serial queue worker wall time by phase - #248
Open
iskakaushik wants to merge 1 commit into
Open
iskakaushik wants to merge 1 commit into
iskakaushik wants to merge 1 commit into
Conversation
iskakaushik
force-pushed
the
kaushik/queue-worker-time-metrics
branch
from
October 20, 2026 14:38
98d3902 to
250e704
Compare
8 tasks
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
from
November 10, 2026 18:13
250e704 to
6001ea7
Compare
harshil-goel
marked this pull request as ready for review
November 10, 2026 18:15
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
from
November 10, 2026 19:29
6001ea7 to
ee26af8
Compare
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
2 times, most recently
from
November 11, 2026 07:25
0e6da93 to
14987ea
Compare
serprex
reviewed
Nov 11, 2026
| ## Open | ||
|
|
||
| - Debug exposition flag for the debug tier. | ||
| - `docker/grafana` dashboard: trim to a local-dev view or delete; the |
Member
There was a problem hiding this comment.
we should be making this an in-tree reference on what metrics matter
serprex
approved these changes
Nov 11, 2026
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
2 times, most recently
from
November 11, 2026 08:58
1bcb709 to
dfb1824
Compare
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
3 times, most recently
from
November 11, 2026 11:38
b808a93 to
f0867d3
Compare
serprex
approved these changes
Nov 11, 2026
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
2 times, most recently
from
November 18, 2026 05:11
0f576dc to
8628f0f
Compare
harshil-goel
force-pushed
the
kaushik/queue-worker-time-metrics
branch
from
November 18, 2026 08:12
8628f0f to
bd16240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One counter family for where every serial worker spends its wall time.
walshadow_worker_seconds_total{worker,state}worker:pump,queue,batcher,inserter, and during a bootstrapbackup_tap,backup_walkstate:busy(own work),idle(waiting for input),blocked_in(waiting on a result it already requested),blocked_out(waiting to hand work downstream)For
pump,queueandbatcherthe states are disjoint and sum to about 1 s/s.inserteris summed over the pool and itsbusyincludes the ClickHouse round trip, failed attempts included.backup_tapandbackup_walkrun once per backup part in parallel, andbackup_tapbusy includes its wait onbackup_walk.Pipeline rows and backup rows are published by different writers and merged, so a session that bootstrapped keeps both.
Breaking
Removed, now members of the family above:
walshadow_pump_queue_wait_seconds_total{worker="pump",state="blocked_out"}walshadow_bootstrap_tap_seconds_total{worker="backup_tap",state="busy"}walshadow_bootstrap_decode_seconds_total{worker="backup_walk",state="busy"}walshadow_bootstrap_channel_block_seconds_total{worker="backup_walk",state="blocked_out"}PromQL
Tests
worker_clock_accounts_busy_and_idle,worker_clock_accounts_blocked_inbootstrap_gauges_keep_pipeline_worker_rowsrender_emits_plan_families_labelledAlso adds
plans/observability.md, the metric naming plan the rest of the stack follows.