London | ITP-Jan-2026 | Ping Wang | Sprint 3 | Quote Generator Sprint 3/quote generator#1036
Open
pathywang wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
London | ITP-Jan-2026 | Ping Wang | Sprint 3 | Quote Generator Sprint 3/quote generator#1036pathywang wants to merge 5 commits intoCodeYourFuture:mainfrom
pathywang wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
pathywang
added
the
Needs Review
cjyuan
reviewed
Mar 28, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
While Lighthouse score is not part of the requirement, it's a good to keep the score at 100.
| <h1>hello there</h1> | ||
| <p id="quote"></p> | ||
| <p id="author"></p> | ||
| <p class="container">Test</p> |
Contributor
There was a problem hiding this comment.
What's the purpose of this element (line 14)?
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
|
|
||
| console.log(pickFromArray(quotes)); |
Contributor
There was a problem hiding this comment.
Any unnecessary code should be removed to keep our code clean.
Comment on lines
+508
to
+510
| button.addEventListener("click", showQuote); | ||
|
|
||
| showQuote(); No newline at end of file |
Contributor
There was a problem hiding this comment.
Placing all the "run on load" code in one place is a good practice.
Would be even better to place the code inside a function to make it clearer that "this is what runs when the page loads."
For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
It did take me a while to get around about this course work because it is quite different from previous single JavaScript code work.