Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | ToDo List App#1136
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | ToDo List App#1136mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Author
|
Hi @cifarquhar, As I submit my Pull Request for the ToDo List App, I want to take a moment to thank you for all your efforts and the valuable knowledge you share with us in this course. For this task, I have successfully implemented the mass delete feature for completed ToDos, making sure the business logic in Thank you again for your time and continuous support! Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Reviewers / CodeYourFuture Team,
I have completed the ToDo List App project for Sprint 3. I am excited to share that I have successfully implemented the mandatory requirement for the mass delete feature.
🎯 Acceptance Criteria Met:
index.htmlwith the correct ID.deleteCompleted(todoList)function intodos.mjsto remove all completed tasks.todos.test.mjsto verify the logic works correctly (including edge cases).deleteCompletedTodosfunction inscript.mjsand successfully updated the DOM.💻 Technical Implementation Details:
forloop in thedeleteCompletedfunction. This approach ensures that modifying the array length during iteration does not cause index shifting or skip any items, which is a common issue when usingsplice()in a standard forward loop.npm test) are passing successfully.Thank you for your time and feedback!
Best regards,
Mahmoud Shaabo